Skip to content

black_box: silence unused_mut warning when building with cfg(miri) - #76823

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:black-box-warn
Sep 20, 2020
Merged

black_box: silence unused_mut warning when building with cfg(miri)#76823
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:black-box-warn

Conversation

@RalfJung

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@joshtriplett

Copy link
Copy Markdown
Member

Shouldn't this use cfg_attr so that it only applies on miri?

@RalfJung

Copy link
Copy Markdown
MemberAuthor

Sure, I can do that. The existing warning also didn't have the cfg_attr, that's why I stuck to that style.

@RalfJung

RalfJung commented Sep 17, 2020

Copy link
Copy Markdown
MemberAuthor

@joshtriplett Done that. I also removed the existing attribute as it seems unnecessary.

@joshtriplett

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1dd3df6 has been approved by joshtriplett

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2020
@RalfJung

Copy link
Copy Markdown
MemberAuthor

@bors rollup

RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 19, 2020
…lett
black_box: silence unused_mut warning when building with cfg(miri)
@RalfJungRalfJung mentioned this pull request Sep 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…lett
black_box: silence unused_mut warning when building with cfg(miri)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…lett
black_box: silence unused_mut warning when building with cfg(miri)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…lett
black_box: silence unused_mut warning when building with cfg(miri)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 20, 2020
…lett
black_box: silence unused_mut warning when building with cfg(miri)
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
…lett
black_box: silence unused_mut warning when building with cfg(miri)
@RalfJungRalfJung mentioned this pull request Sep 20, 2020
@RalfJungRalfJung mentioned this pull request Sep 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
Rollup of 15 pull requests
Successful merges:
- rust-lang#76722 (Test and fix Send and Sync traits of BTreeMap artefacts)
- rust-lang#76766 (Extract some intrinsics out of rustc_codegen_llvm)
- rust-lang#76800 (Don't generate bootstrap usage unless it's needed)
- rust-lang#76809 (simplfy condition in ItemLowerer::with_trait_impl_ref())
- rust-lang#76815 (Fix wording in mir doc)
- rust-lang#76818 (Don't compile regex at every function call.)
- rust-lang#76821 (Remove redundant nightly features)
- rust-lang#76823 (black_box: silence unused_mut warning when building with cfg(miri))
- rust-lang#76825 (use `array_windows` instead of `windows` in the compiler)
- rust-lang#76827 (fix array_windows docs)
- rust-lang#76828 (use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip))
- rust-lang#76840 (Move to intra doc links in core/src/future)
- rust-lang#76845 (Use intra docs links in core::{ascii, option, str, pattern, hash::map})
- rust-lang#76853 (Use intra-doc links in library/core/src/task/wake.rs)
- rust-lang#76871 (support panic=abort in Miri)
Failed merges:
r? `@ghost`
@bors
bors merged commit df4e4ef into rust-lang:masterSep 20, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 20, 2020
@RalfJung
RalfJung deleted the black-box-warn branch September 21, 2020 07:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung@rust-highfive@joshtriplett@bors@rustbot