Skip to content

use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip) - #76828

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:clippy_manual_strip
Sep 20, 2020
Merged

use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)#76828
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:clippy_manual_strip

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@lcnr

lcnr commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

Thanks 👍

I once again think that replace_prefix should be removed from FnCtxt and just take &str instead of impl AsRef<str>, but that isn't really related to this PR https://doc.rust-lang.org/nightly/nightly-rustc/rustc_typeck/check/struct.FnCtxt.html#method.replace_prefix

@bors r+ rollup

@bors

bors commented Sep 17, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 012974d has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2020
@lcnr

lcnr commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

r? @lcnr

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 17, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 19, 2020
…=lcnr
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
@RalfJungRalfJung mentioned this pull request Sep 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…=lcnr
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…=lcnr
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…=lcnr
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
This was referenced Sep 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
…=lcnr
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
…=lcnr
use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
@RalfJungRalfJung mentioned this pull request Sep 20, 2020
@RalfJungRalfJung mentioned this pull request Sep 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
Rollup of 15 pull requests
Successful merges:
- rust-lang#76722 (Test and fix Send and Sync traits of BTreeMap artefacts)
- rust-lang#76766 (Extract some intrinsics out of rustc_codegen_llvm)
- rust-lang#76800 (Don't generate bootstrap usage unless it's needed)
- rust-lang#76809 (simplfy condition in ItemLowerer::with_trait_impl_ref())
- rust-lang#76815 (Fix wording in mir doc)
- rust-lang#76818 (Don't compile regex at every function call.)
- rust-lang#76821 (Remove redundant nightly features)
- rust-lang#76823 (black_box: silence unused_mut warning when building with cfg(miri))
- rust-lang#76825 (use `array_windows` instead of `windows` in the compiler)
- rust-lang#76827 (fix array_windows docs)
- rust-lang#76828 (use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip))
- rust-lang#76840 (Move to intra doc links in core/src/future)
- rust-lang#76845 (Use intra docs links in core::{ascii, option, str, pattern, hash::map})
- rust-lang#76853 (Use intra-doc links in library/core/src/task/wake.rs)
- rust-lang#76871 (support panic=abort in Miri)
Failed merges:
r? `@ghost`
@bors
bors merged commit bfa1904 into rust-lang:masterSep 20, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 20, 2020
@matthiaskrgr
matthiaskrgr deleted the clippy_manual_strip branch January 25, 2025 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@rust-highfive@lcnr@bors@ecstatic-morse@rustbot