stabilize const_int_pow by tspiteri · Pull Request #76829 · rust-lang/rust

tspiteri · 2020-09-17T09:26:58Z

This also requires stabilizing constctlz for const ctlz_nonzero.

rust-highfive · 2020-09-17T09:27:02Z

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

tspiteri · 2020-09-17T09:50:42Z

This PR stabilized const for the following public methods:

{i*,u*}::checked_pow
{i*,u*}::saturating_pow
{i*,u*}::wrapping_pow
{i*,u*}::overflowing_pow
{i*,u*}::pow
u*::next_power_of_two
u*::checked_next_power_of_two
u*::wrapping_next_power_of_two (the method itself is still unstable)

Mark-Simulacrum · 2020-09-18T21:16:12Z

r? @KodrAus to kick off libs FCP here, diff in PR looks good from an impl perspective

bors · 2020-09-19T19:14:17Z

☔ The latest upstream changes (presumably #76327) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

bors · 2020-09-23T08:45:38Z

☔ The latest upstream changes (presumably #76850) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

tspiteri · 2020-10-02T17:32:42Z

I've just force-pushed an update with the since field set to "1.49.0" since this cannot possibly complete FCP before 1.48.0 goes into beta.

KodrAus · 2020-10-05T03:10:18Z

@rfcbot fcp merge

See: #76829 (comment)

This stabilizes a few more const methods on integers.

cc @rust-lang/wg-const-eval

rfcbot · 2020-10-05T03:10:19Z

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2020-11-13T00:05:00Z

🔔 This is now entering its final comment period, as per the review above. 🔔

bors · 2020-11-18T20:45:31Z

☔ The latest upstream changes (presumably #79167) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

oli-obk · 2020-11-23T07:23:24Z

@bors r-

yea, please adjust the stabilization date, too

tspiteri · 2020-11-23T09:31:27Z

Done.

oli-obk · 2020-11-23T09:33:56Z

@bors r+

bors · 2020-11-23T09:33:58Z

📌 Commit a6bcf7a has been approved by oli-obk

bors · 2020-11-23T09:45:26Z

⌛ Testing commit a6bcf7a with merge b1801ff6fe6c747687a9e423da6fda1d0c736835...

bors · 2020-11-23T10:02:41Z

💔 Test failed - checks-actions

oli-obk · 2020-11-23T10:50:43Z

@bors retry gzip failures in CI

…as-schievink Rollup of 10 pull requests Successful merges: - rust-lang#76829 (stabilize const_int_pow) - rust-lang#79080 (MIR visitor: Don't treat debuginfo field access as a use of the struct) - rust-lang#79236 (const_generics: assert resolve hack causes an error) - rust-lang#79287 (Allow using generic trait methods in `const fn`) - rust-lang#79324 (Use Option::and_then instead of open-coding it) - rust-lang#79325 (Reduce boilerplate with the `?` operator) - rust-lang#79330 (Fix typo in comment) - rust-lang#79333 (doc typo) - rust-lang#79337 (Use Option::map instead of open coding it) - rust-lang#79343 (Add my (`@flip1995)` work mail to the mailmap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

rust-highfive assigned Mark-Simulacrum Sep 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020

jonas-schievink added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api [DEPRECATED; DO NOT USE] labels Sep 17, 2020

rust-highfive assigned KodrAus and unassigned Mark-Simulacrum Sep 18, 2020

tspiteri force-pushed the const-int-pow branch from 26d50cb to 5070d51Compare September 21, 2020 12:58

tspiteri force-pushed the const-int-pow branch from 5070d51 to 7db7b41Compare September 23, 2020 09:02

tspiteri force-pushed the const-int-pow branch from 7db7b41 to 4a062a1Compare October 2, 2020 17:31

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 5, 2020

oli-obk approved these changes Oct 5, 2020
View reviewed changes

crlf0710 added S-waiting-on-team and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2020

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 13, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2020

tspiteri force-pushed the const-int-pow branch from 4a062a1 to a6bcf7aCompare November 23, 2020 08:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2020

jonas-schievink mentioned this pull request Nov 23, 2020
Rollup of 10 pull requests #79345
Merged

bors merged commit 703f176 into rust-lang:masterNov 23, 2020

rustbot added this to the 1.50.0 milestone Nov 23, 2020

tspiteri deleted the const-int-pow branch November 23, 2020 21:30

spastorino removed the to-announce Announce this issue on triage meeting label Dec 3, 2020

vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 9, 2020
Remove const_int_pow feature flag
7d9128c
const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

vlvrd mentioned this pull request Dec 9, 2020
Remove const_int_pow feature flag nimiq/core-rs-albatross#207
Merged

vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 11, 2020
Remove const_int_pow feature flag
51d1caa
const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 14, 2020
Remove const_int_pow feature flag
a2c3c00
const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

vlvrd pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 15, 2020
Remove const_int_pow feature flag
e187c80
const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

jgraef pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 17, 2020
Remove const_int_pow feature flag
53f787b
const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

jgraef pushed a commit to nimiq/core-rs-albatross that referenced this pull request Dec 17, 2020
Remove const_int_pow feature flag
342e5cf
const_int_pow was stabilized in Rust 1.50.0 rust-lang/rust#76829

Uh oh!

Uh oh!

Conversation

tspiteri commented Sep 17, 2020

Uh oh!

rust-highfive commented Sep 17, 2020

Uh oh!

tspiteri commented Sep 17, 2020

Uh oh!

Mark-Simulacrum commented Sep 18, 2020

Uh oh!

bors commented Sep 19, 2020

Uh oh!

bors commented Sep 23, 2020

Uh oh!

tspiteri commented Oct 2, 2020

Uh oh!

KodrAus commented Oct 5, 2020

Uh oh!

rfcbot commented Oct 5, 2020• edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Nov 13, 2020

Uh oh!

bors commented Nov 18, 2020

Uh oh!

oli-obk commented Nov 23, 2020

Uh oh!

tspiteri commented Nov 23, 2020

Uh oh!

oli-obk commented Nov 23, 2020

Uh oh!

bors commented Nov 23, 2020

Uh oh!

bors commented Nov 23, 2020

Uh oh!

bors commented Nov 23, 2020

Uh oh!

oli-obk commented Nov 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

rfcbot commented Oct 5, 2020•
edited by BurntSushi
Loading