Uh oh!
There was an error while loading. Please reload this page.
Split core/num/mod.rs to smaller mods - #76327
Conversation
bors
commented
Sep 7, 2020
☔ The latest upstream changes (presumably #76422) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Sep 10, 2020
☔ The latest upstream changes (presumably #76540) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
tesuji
commented
Sep 10, 2020
Rebased. |
tesuji
commented
Sep 11, 2020
r? @KodrAus |
bors
commented
Sep 16, 2020
☔ The latest upstream changes (presumably #76804) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
tesuji
commented
Sep 17, 2020
Rebased. |
varkor
commented
Sep 19, 2020
@rust-lang/libs: is there someone who could review this PR? It bitrots quite quickly. |
SimonSapin
commented
Sep 19, 2020
Looks good, thanks! @bors r+ |
bors
commented
Sep 19, 2020
📌 Commit 5cb99ae3a56c07f8f3463bada49c4756ec7a29e0 has been approved by |
bors
commented
Sep 19, 2020
☔ The latest upstream changes (presumably #76912) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
varkor
commented
Sep 19, 2020
tesuji
commented
Sep 19, 2020
Done. Reviewer could run locally to get the diff. |
SimonSapin
commented
Sep 19, 2020
@bors r+ |
bors
commented
Sep 19, 2020
📌 Commit a50ec5f has been approved by |
bors
commented
Sep 19, 2020
bors
commented
Sep 19, 2020
☀️ Test successful - checks-actions, checks-azure |
Note for reviewer:
I split
core/num/mod.rsto these modules:error: For error structs likeParseIntError.shellsdir: For dummy number type modules: std::i32, std::f32, and the likes. Why? See below.int_macrosanduint_macros: Real implementation of all integer types viaint_implanduint_implnonzero: ForNonZero*types and their implementations.wrapping: ForWrapping<T>types.