Skip to content

Changing the alloc() to accept &self instead of &mut self - #76993

Merged
bors merged 7 commits into
rust-lang:masterfrom
blitzerr:alloc-ref
Sep 24, 2020
Merged

Changing the alloc() to accept &self instead of &mut self#76993
bors merged 7 commits into
rust-lang:masterfrom
blitzerr:alloc-ref

Conversation

@blitzerr

@blitzerrblitzerr commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Fixes: #55

This is the first cut. It only makes the change for alloc method.

@rust-highfive

rust-highfive commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2020
@blitzerr

blitzerr commented Sep 21, 2020

Copy link
Copy Markdown
ContributorAuthor

r? @Amanieu cc @TimDiekmann

@blitzerrblitzerr changed the title Changing the alloc() to accept &self instead of &mut self[WIP] Changing the alloc() to accept &self instead of &mut selfSep 21, 2020
TimDiekmann
TimDiekmann reviewed Sep 21, 2020
View reviewed changes
Comment threadlibrary/alloc/src/raw_vec/tests.rs Outdated
@TimDiekmann

TimDiekmann commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Could you rebase onto master and force push so we don't have the changes from all the other commits?

@Amanieu

Amanieu commented Sep 21, 2020

Copy link
Copy Markdown
Member

Can you also change the other methods of AllocRef in this PR?

@blitzerr

blitzerr commented Sep 21, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Could you rebase onto master and force push so we don't have the changes from all the other commits?

Ohh ! I am so sorry for all the junk. I thought I did force push but apparently not :)

Now it is done

@blitzerr

blitzerr commented Sep 21, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Can you also change the other methods of AllocRef in this PR?

@Amanieu I will certainly do that. :) This is my first PR into stdlib. So I wanted all builds to pass cleanly with just the alloc changes. Then I will make the change for all methods in AllocRef. Does that sound okay ?

TimDiekmann
TimDiekmann reviewed Sep 22, 2020
View reviewed changes
Comment threadsrc/test/ui/allocator/custom.rs Outdated
Amanieu
Amanieu reviewed Sep 22, 2020
View reviewed changes
Comment threadlibrary/core/src/alloc/mod.rs
@blitzerr

blitzerr commented Sep 22, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Awesome ! Thanks for being proactive with the PR. I will incorporate all the suggestions.

@blitzerrblitzerr changed the title [WIP] Changing the alloc() to accept &self instead of &mut selfChanging the alloc() to accept &self instead of &mut selfSep 23, 2020
@Amanieu

Amanieu commented Sep 23, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Sep 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2b19b14 has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2020
@bors
Auto merge ofrust-lang#77102- Dylan-DPC:rollup-2jfrg3u, r=Dylan-DPC
c351775
Rollup of 9 pull requests
Successful merges:
- rust-lang#76898 (Record `tcx.def_span` instead of `item.span` in crate metadata)
- rust-lang#76939 (emit errors during AbstractConst building)
- rust-lang#76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
- rust-lang#76993 (Changing the alloc() to accept &self instead of &mut self)
- rust-lang#76994 (fix small typo in docs and comments)
- rust-lang#77017 (Add missing examples on Vec iter types)
- rust-lang#77042 (Improve documentation for ToSocketAddrs)
- rust-lang#77047 (Miri: more informative deallocation error messages)
- rust-lang#77055 (Add #[track_caller] to more panicking Cell functions)
Failed merges:
r? `@ghost`
@bors
bors merged commit a40d79c into rust-lang:masterSep 24, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 24, 2020
al3xtjames added a commit to al3xtjames/r-efi-alloc that referenced this pull request Oct 1, 2020
@al3xtjames
alloc: align with AllocRef trait changes in nightly
42e787d
Needed since rust-lang/rust#76993
Signed-off-by: Alex James <theracermaster@gmail.com>
@al3xtjamesal3xtjames mentioned this pull request Oct 1, 2020
Merged
dvdhrm pushed a commit to r-efi/r-efi-alloc that referenced this pull request Oct 1, 2020
@al3xtjames@dvdhrm
alloc: align with AllocRef trait changes in nightly
58c7085
Needed since rust-lang/rust#76993
Signed-off-by: Alex James <theracermaster@gmail.com>
parasyte pushed a commit to parasyte/allocator-suite that referenced this pull request Oct 21, 2020
Jay Oster
Update for experimental allocator_api
60b7791
- Incorporates changes for:
- rust-lang/rust#76993
- rust-lang/rust#77315
@parasyteparasyte mentioned this pull request Oct 21, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments
+1 more reviewer
@TimDiekmannTimDiekmannTimDiekmann left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@AmanieuAmanieu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

Change AllocRef to take &self

7 participants

@blitzerr@rust-highfive@TimDiekmann@Amanieu@bors@joshtriplett@rustbot