Skip to content

Improve documentation for ToSocketAddrs - #77042

Merged
bors merged 3 commits into
rust-lang:masterfrom
imbolc:patch-2
Sep 24, 2020
Merged

Improve documentation for ToSocketAddrs#77042
bors merged 3 commits into
rust-lang:masterfrom
imbolc:patch-2

Conversation

@imbolc

@imbolcimbolc commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

I little clarification

@imbolc
Update addr.rs
2a40b63
I little clarification
@rust-highfive

rust-highfive commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2020
pickfire
pickfire reviewed Sep 22, 2020
View reviewed changes
Comment threadlibrary/std/src/net/addr.rs Outdated
pickfire
pickfire reviewed Sep 22, 2020
View reviewed changes
Comment threadlibrary/std/src/net/addr.rs Outdated
@jyn514jyn514 changed the title Update addr.rsImprove documentation for ToSocketAddrsSep 22, 2020
@jyn514jyn514 added A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api [DEPRECATED; DO NOT USE] labels Sep 22, 2020
imbolcand others added 2 commits September 22, 2020 19:09
@imbolc@pickfire
Update library/std/src/net/addr.rs
5ab714f
Co-authored-by: Ivan Tham <pickfire@riseup.net>
@imbolc@pickfire
Update library/std/src/net/addr.rs
4622ceb
Co-authored-by: Ivan Tham <pickfire@riseup.net>
@kennytm

kennytm commented Sep 22, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4622ceb has been approved by kennytm

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2020
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Sep 22, 2020
@ecstatic-morse
Rollup merge ofrust-lang#77042- imbolc:patch-2, r=kennytm
cff8489
Improve documentation for ToSocketAddrs
I little clarification
@ecstatic-morseecstatic-morse mentioned this pull request Sep 22, 2020
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Sep 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2020
@bors
Auto merge ofrust-lang#77102- Dylan-DPC:rollup-2jfrg3u, r=Dylan-DPC
c351775
Rollup of 9 pull requests
Successful merges:
- rust-lang#76898 (Record `tcx.def_span` instead of `item.span` in crate metadata)
- rust-lang#76939 (emit errors during AbstractConst building)
- rust-lang#76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
- rust-lang#76993 (Changing the alloc() to accept &self instead of &mut self)
- rust-lang#76994 (fix small typo in docs and comments)
- rust-lang#77017 (Add missing examples on Vec iter types)
- rust-lang#77042 (Improve documentation for ToSocketAddrs)
- rust-lang#77047 (Miri: more informative deallocation error messages)
- rust-lang#77055 (Add #[track_caller] to more panicking Cell functions)
Failed merges:
r? `@ghost`
@bors
bors merged commit 049ba0c into rust-lang:masterSep 24, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@pickfirepickfirepickfire left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@kennytmkennytm

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-ioArea: `std::io`, `std::fs`, `std::net` and `std::path`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

7 participants

@imbolc@rust-highfive@kennytm@bors@pickfire@jyn514@rustbot