Uh oh!
There was an error while loading. Please reload this page.
Fix typo in vec doc "tries to reserves" - #77192
Conversation
rust-highfive
commented
Sep 25, 2020
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
pickfire
commented
Sep 25, 2020
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
I think if you have a bunch of improvements like this I would personally prefer to see a single PR rather than tiny PRs, easier to review in batches. (And less commits editing docs, better git history, etc.)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Not exactly, I just send these sort of PR once I found it, I don't find it all at once since it is scattered everywhere. But yeah, I have another batch of PR on vec bench but I didn't send it in batch since it is easier to just change the file in github and let others review one by one. But I also don't want to remove a commit if one of the change is not good so I just send it one by one. See #77185 for one of them. But yeah these (this one) PRs are ad-hoc, only those that I ping myself are in batch. |
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Sep 30, 2020
r=me with commits squashed |
pickfire
commented
Oct 1, 2020
@Mark-Simulacrum Can I create a new pull request for it? I am lazy to rebase. |
Mark-Simulacrum
commented
Oct 1, 2020
I am unopposed. |
Fix typo in vec doc "tries to reserves" Superseeds rust-lang#77192
No description provided.