Skip to content

Remove unused #[allow(...)] statements from compiler/ - #77211

Merged
bors merged 1 commit into
rust-lang:masterfrom
est31:remove_unused_allow
Sep 26, 2020
Merged

Remove unused #[allow(...)] statements from compiler/#77211
bors merged 1 commit into
rust-lang:masterfrom
est31:remove_unused_allow

Conversation

@est31

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2020
@jyn514jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

I guess we really should implement the expect part of #54503 and just use that everywhere

r? @oli-obk

@rust-highfiverust-highfive assigned oli-obk and unassigned eddybSep 26, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 12187b7 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 26, 2020
Remove unused #[allow(...)] statements from compiler/
@RalfJungRalfJung mentioned this pull request Sep 26, 2020
@est31

Copy link
Copy Markdown
MemberAuthor

Btw I'm not sure about the lints in compiler/rustc_data_structures/src/flock.rs either, but it has three different implementations for three different platforms, so maybe it only fires on one platform, so I just kept it where it is.

@RalfJungRalfJung mentioned this pull request Sep 26, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2020
Rollup of 12 pull requests
Successful merges:
- rust-lang#75454 (Explicitly document the size guarantees that Option makes.)
- rust-lang#76631 (Add `x.py setup`)
- rust-lang#77076 (Add missing code examples on slice iter types)
- rust-lang#77093 (merge `need_type_info_err(_const)`)
- rust-lang#77122 (Add `#![feature(const_fn_floating_point_arithmetic)]`)
- rust-lang#77127 (Update mdBook)
- rust-lang#77161 (Remove TrustedLen requirement from BuilderMethods::switch)
- rust-lang#77166 (update Miri)
- rust-lang#77181 (Add doc alias for pointer primitive)
- rust-lang#77204 (Remove stray word from `ClosureKind::extends` docs)
- rust-lang#77207 (Rename `whence` to `span`)
- rust-lang#77211 (Remove unused #[allow(...)] statements from compiler/)
Failed merges:
- rust-lang#77170 (Remove `#[rustc_allow_const_fn_ptr]` and add `#![feature(const_fn_fn_ptr_basics)]`)
r? `@ghost`
@bors
bors merged commit 9e02642 into rust-lang:masterSep 26, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@est31@rust-highfive@oli-obk@bors@eddyb@jyn514@rustbot