Skip to content

Add asm! support for mips64 - #77337

Merged
bors merged 4 commits into
rust-lang:masterfrom
tesuji:asm-mips64
Oct 10, 2020
Merged

Add asm! support for mips64#77337
bors merged 4 commits into
rust-lang:masterfrom
tesuji:asm-mips64

Conversation

@tesuji

@tesujitesuji commented Sep 29, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Updated src/doc/unstable-book/src/library-features/asm.md.
  • No vector type support. I don't know much about those types.

cc #76839

@jyn514jyn514 added A-inline-assembly Area: Inline assembly (`asm!(…)`) F-asm `#![feature(asm)]` (not `llvm_asm`) O-MIPS Target: MIPS processors labels Sep 29, 2020
@tesuji
tesujiforce-pushed the asm-mips64 branch 2 times, most recently from c9140cb to 4fde576CompareSeptember 30, 2020 10:43
@tesuji
tesuji marked this pull request as ready for review September 30, 2020 11:00
@tesuji

tesuji commented Sep 30, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2020
Amanieu
Amanieu reviewed Sep 30, 2020
View reviewed changes
Comment threadcompiler/rustc_target/src/asm/mips.rs Outdated
Comment threadsrc/test/assembly/asm/mips64-types.rs Outdated
Comment threadcompiler/rustc_codegen_llvm/src/asm.rs Outdated
@AmanieuAmanieu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2020
@tesuji

tesuji commented Oct 1, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Please tell me to git squash before merging!

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 1, 2020
Amanieu
Amanieu reviewed Oct 2, 2020
View reviewed changes
Comment threadcompiler/rustc_target/src/asm/mips.rs Outdated
Comment threadcompiler/rustc_target/src/asm/mips.rs Outdated

@AmanieuAmanieuOct 1, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to support F64 here with the same bitcast adjustment you did for F32.

@tesujitesujiOct 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have hard-float by default for mips, I don't know how people enable soft-float FPU.
Is it important to support those operations ?

@AmanieuAmanieuOct 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just for consistency since all the other architectures support FP values in integer registers.

@tesujitesujiOct 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I added it then. Although I don't know how useful they are.

@Amanieu

Amanieu commented Oct 3, 2020

Copy link
Copy Markdown
Member

LGTM

@tesuji@Amanieu
mips32: Add f64 hard-float support
6cb062d
co-authored-by: Amanieu <amanieu@gmail.com>
@tesuji

tesuji commented Oct 4, 2020

Copy link
Copy Markdown
ContributorAuthor

rebased.

@Amanieu

Amanieu commented Oct 4, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f1d9b514471c47da029dbf0ac548a7b22b45e5f7 has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2020
@tesuji

tesuji commented Oct 4, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Sorry, I didn't split "Add asm! support for mips64" and "Removes reg aliases since there are many ABIs: o32/n32/n64"
cleanly. Should be good now.

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2020
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2020
@Amanieu

Amanieu commented Oct 10, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4d570fb has been approved by Amanieu

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2020
@bors

bors commented Oct 10, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4d570fb with merge 7bc5839...

@bors

bors commented Oct 10, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing 7bc5839 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2020
@bors
bors merged commit 7bc5839 into rust-lang:masterOct 10, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 10, 2020
@tesuji
tesuji deleted the asm-mips64 branch October 11, 2020 01:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AmanieuAmanieuAmanieu left review comments

Assignees

@AmanieuAmanieu

Labels

A-inline-assemblyArea: Inline assembly (`asm!(…)`)F-asm`#![feature(asm)]` (not `llvm_asm`)merged-by-borsThis PR was explicitly merged by bors.O-MIPSTarget: MIPS processorsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tesuji@Amanieu@bors@jyn514@rustbot