-Zvalidate-mir: Assert that storage is allocated on local use by jonas-schievink · Pull Request #77369 · rust-lang/rust

jonas-schievink · 2020-09-30T17:00:22Z

This extends the MIR validator to check that locals are only used when their backing storage is currently allocated via StorageLive.

The result of this is that miscompilations such as #77359 are caught and turned into ICEs.

The PR currently fails tests because miscompilations such as #77359 are caught and turned into ICEs.

I have confirmed that tests pass (even with -Zvalidate-mir) once SimplifyArmIdentity is turned into a no-op (except mir-opt tests, of course).

rust-highfive · 2020-09-30T17:00:25Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

jonas-schievink · 2020-09-30T17:01:05Z

r? @wesleywiser

We now run an extra data flow pass, so this could impact perf.

@bors try @rust-timer queue

rust-timer · 2020-09-30T17:01:06Z

Awaiting bors try build completion

bors · 2020-09-30T17:01:16Z

⌛ Trying commit 36365b35ee72d8cfde7949f55517832878a754c0 with merge d952cf6887b310e5009157bddd5894b5f54cb31b...

jonas-schievink · 2020-09-30T17:10:20Z

@bors try-

Bootstrap also fails, because miscompilations such as #77359 are caught and turned into ICEs.

rust-log-analyzer · 2020-09-30T17:20:55Z

The job dist-x86_64-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 Compiling gimli v0.22.0
Compiling object v0.20.0
Compiling miniz_oxide v0.4.0
Compiling hashbrown v0.9.0
error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:4691 ~ core[5bc6]::iter::adapters::{impl#95}::size_hint), const_param_did: None }) (end of phase Optimization) at bb0[0]:
use of local _11, which has no storage here
|
|
2467 | if self.n == 0 {
|
|
= note: delayed at compiler/rustc_mir/src/transform/validate.rs:163:36
thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.48.0-nightly (d952cf688 2020-09-30) running on x86_64-unknown-linux-gnu
note: compiler flags: -Z macro-backtrace -Z save-analysis -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=1 -C linker=clang -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C embed-bitcode=yes --crate-type lib
note: some of the compiler flags provided by cargo are hidden
error: could not compile `core`.
To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:2370 ~ object[fa71]::read::traits::Object::symbol_data), const_param_did: None }) (end of phase Optimization) at bb0[0]:
use of local _51, which has no storage here
--> /cargo/registry/src/github.com-1ecc6299db9ec823/object-0.20.0/src/read/traits.rs:97:9
|
97 | / if symbol.is_undefined() {
98 | | return Ok(None);
| |_________^
|
|
= note: delayed at compiler/rustc_mir/src/transform/validate.rs:163:36
thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.48.0-nightly (d952cf688 2020-09-30) running on x86_64-unknown-linux-gnu
note: compiler flags: -Z macro-backtrace -Z save-analysis -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=0 -C linker=clang -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C embed-bitcode=yes --crate-type lib
note: some of the compiler flags provided by cargo are hidden
error: build failed
error: build failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace profiler compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "--message-format" "json-render-diagnostics"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
Build completed unsuccessfully in 0:14:56
== clock drift check ==
local time: Wed Sep 30 17:20:46 UTC 2020
local time: Wed Sep 30 17:20:46 UTC 2020
network time: Wed, 30 Sep 2020 17:20:46 GMT
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (6062) (python)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

jonas-schievink · 2020-09-30T17:29:35Z

@bors r-

jonas-schievink · 2020-09-30T17:29:57Z

@bors retry

wesleywiser · 2020-10-01T14:19:00Z

@bors try

bors · 2020-10-01T14:19:11Z

⌛ Trying commit 36365b35ee72d8cfde7949f55517832878a754c0 with merge 1bdd5353b898fca7dc1cc8e53331d72c296eea8a...

jonas-schievink · 2020-10-01T14:24:02Z

This needs #77396 before bootstrapping will work

rust-log-analyzer · 2020-10-01T14:38:27Z

The job dist-x86_64-linux of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

 Compiling gimli v0.22.0
Compiling object v0.20.0
Compiling miniz_oxide v0.4.0
Compiling hashbrown v0.9.0
error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:4693 ~ core[5bc6]::iter::adapters::{impl#95}::size_hint), const_param_did: None }) (end of phase Optimization) at bb0[0]:
use of local _11, which has no storage here
|
|
2477 | if self.n == 0 {
|
|
= note: delayed at compiler/rustc_mir/src/transform/validate.rs:163:36
thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.48.0-nightly (1bdd5353b 2020-10-01) running on x86_64-unknown-linux-gnu
note: compiler flags: -Z macro-backtrace -Z save-analysis -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=1 -C linker=clang -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C embed-bitcode=yes --crate-type lib
note: some of the compiler flags provided by cargo are hidden
error: could not compile `core`.
To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:2370 ~ object[fa71]::read::traits::Object::symbol_data), const_param_did: None }) (end of phase Optimization) at bb0[0]:
use of local _51, which has no storage here
--> /cargo/registry/src/github.com-1ecc6299db9ec823/object-0.20.0/src/read/traits.rs:97:9
|
97 | / if symbol.is_undefined() {
98 | | return Ok(None);
| |_________^
|
|
= note: delayed at compiler/rustc_mir/src/transform/validate.rs:163:36
thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:961:13
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.48.0-nightly (1bdd5353b 2020-10-01) running on x86_64-unknown-linux-gnu
note: compiler flags: -Z macro-backtrace -Z save-analysis -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=0 -C linker=clang -C link-args=-Wl,-rpath,$ORIGIN/../lib -C prefer-dynamic -C embed-bitcode=yes --crate-type lib
note: some of the compiler flags provided by cargo are hidden
error: build failed
error: build failed
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace profiler compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "--message-format" "json-render-diagnostics"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
Build completed unsuccessfully in 0:14:52
== clock drift check ==
local time: Thu Oct 1 14:38:18 UTC 2020
local time: Thu Oct 1 14:38:18 UTC 2020
network time: Thu, 01 Oct 2020 14:38:18 GMT
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (5347) (python)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-10-01T14:38:37Z

💔 Test failed - checks-actions

jonas-schievink · 2020-10-01T23:52:51Z

Pushed a temp. commit that disables the pass to get perf data

@bors try @rust-timer queue

rust-timer · 2020-10-01T23:52:52Z

Awaiting bors try build completion

bors · 2020-10-01T23:53:03Z

⌛ Trying commit e32bb31b958b87a677515ca5881169f88a20aca6 with merge 6c70b42c961226e0059a4aa0bef7f315aad8ad8c...

bors · 2020-10-02T00:33:40Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: 6c70b42c961226e0059a4aa0bef7f315aad8ad8c (6c70b42c961226e0059a4aa0bef7f315aad8ad8c)

rust-timer · 2020-10-02T00:33:41Z

Queued 6c70b42c961226e0059a4aa0bef7f315aad8ad8c with parent 8fe73e8, future comparison URL.

rust-timer · 2020-10-02T04:27:00Z

Finished benchmarking try commit (6c70b42c961226e0059a4aa0bef7f315aad8ad8c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

wesleywiser

This looks great and #77396 just merged so you should be able to bootstrap now.

jonas-schievink · 2020-10-02T15:21:45Z

@bors r=wesleywiser

bors · 2020-10-02T15:21:47Z

📌 Commit c47011f has been approved by wesleywiser

bors · 2020-10-02T15:41:03Z

⌛ Testing commit c47011f with merge c7ec262b251125405b06f5b4f71a143146f54a93...

bors · 2020-10-02T16:29:19Z

💔 Test failed - checks-actions

jonas-schievink · 2020-10-02T16:31:09Z

= note: LINK : fatal error LNK1102: out of memory

@bors retry

bors · 2020-10-02T17:20:19Z

⌛ Testing commit c47011f with merge be38081...

bors · 2020-10-02T19:41:59Z

☀️ Test successful - checks-actions, checks-azure
Approved by: wesleywiser
Pushing be38081 to master...

…cation, r=wesleywiser Disable MatchBranchSimplification This optimization can result in unsoundness, because it introduces additional uses of a place holding the discriminant value without ensuring that it is valid to do so. Found by validation from rust-lang#77369 / rust-lang#78147.

rust-highfive assigned estebank Sep 30, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2020

rust-highfive assigned wesleywiser and unassigned estebank Sep 30, 2020

jonas-schievink mentioned this pull request Sep 30, 2020
Segfaults/corruption when reading an enum in release mode #77359
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2020

jonas-schievink changed the title ~~validate: storage must be allocated on local use~~-Zvalidate-mir: Assert that storage is allocated on local useSep 30, 2020

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 1, 2020

validate: storage must be allocated on local use
c1a431e

wesleywiser approved these changes Oct 2, 2020
View reviewed changes

jonas-schievink added 2 commits October 2, 2020 16:50

validate: skip debuginfo
acc150b

Ignore now-broken mir-opt test
c47011f

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 2, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 2, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2020

bors merged commit be38081 into rust-lang:masterOct 2, 2020

rustbot added this to the 1.48.0 milestone Oct 2, 2020

jonas-schievink deleted the validate-storage-liveness branch October 3, 2020 20:47

jonas-schievink mentioned this pull request Oct 3, 2020
Spurious linker OOM in CI #77510
Closed

tmiasko mentioned this pull request Oct 20, 2020
Disable MatchBranchSimplification #78151
Merged

tmiasko mentioned this pull request Oct 21, 2020
InstCombine introduces an incorrect use of a local after its storage has ended #78192
Closed

Uh oh!

Uh oh!

Conversation

jonas-schievink commented Sep 30, 2020

Uh oh!

rust-highfive commented Sep 30, 2020

Uh oh!

jonas-schievink commented Sep 30, 2020

Uh oh!

rust-timer commented Sep 30, 2020

Uh oh!

bors commented Sep 30, 2020

Uh oh!

jonas-schievink commented Sep 30, 2020

Uh oh!

rust-log-analyzer commented Sep 30, 2020

Uh oh!

jonas-schievink commented Sep 30, 2020

Uh oh!

jonas-schievink commented Sep 30, 2020

Uh oh!

wesleywiser commented Oct 1, 2020

Uh oh!

bors commented Oct 1, 2020

Uh oh!

jonas-schievink commented Oct 1, 2020

Uh oh!

rust-log-analyzer commented Oct 1, 2020

Uh oh!

bors commented Oct 1, 2020

Uh oh!

jonas-schievink commented Oct 1, 2020

Uh oh!

rust-timer commented Oct 1, 2020

Uh oh!

bors commented Oct 1, 2020

Uh oh!

bors commented Oct 2, 2020

Uh oh!

rust-timer commented Oct 2, 2020

Uh oh!

rust-timer commented Oct 2, 2020

Uh oh!

wesleywiser left a comment

Choose a reason for hiding this comment

Uh oh!

jonas-schievink commented Oct 2, 2020

Uh oh!

bors commented Oct 2, 2020

Uh oh!

bors commented Oct 2, 2020

Uh oh!

bors commented Oct 2, 2020

Uh oh!

jonas-schievink commented Oct 2, 2020

Uh oh!

bors commented Oct 2, 2020

Uh oh!

bors commented Oct 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants