Skip to content

Disable the SimplifyArmIdentity mir-opt - #77396

Merged
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:disable-simplifyarmidentity
Oct 2, 2020
Merged

Disable the SimplifyArmIdentity mir-opt#77396
bors merged 1 commit into
rust-lang:masterfrom
wesleywiser:disable-simplifyarmidentity

Conversation

@wesleywiser

Copy link
Copy Markdown
Member

The optimization still has some bugs that need to be worked out
such as #77359.

We can try re-enabling this again after the known issues are resolved.

r? @oli-obk

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

r=me with 32 bit files updated

@wesleywiser
wesleywiserforce-pushed the disable-simplifyarmidentity branch 2 times, most recently from 13fe848 to 52a248cCompareOctober 1, 2020 12:55
The optimization still has some bugs that need to be worked out
such as rust-lang#77359.
We can try re-enabling this again after the known issues are resolved.
@wesleywiser
wesleywiserforce-pushed the disable-simplifyarmidentity branch from 52a248c to f9d7720CompareOctober 2, 2020 00:31
@wesleywiser

Copy link
Copy Markdown
MemberAuthor

@bors r=oli-obk rollup=never p=5

Closes an unsound nightly regression.

@bors

bors commented Oct 2, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f9d7720 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
@bors

bors commented Oct 2, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f9d7720 with merge 9cec822f5e3bf56415f98113bf85a1d0904d897e...

@bors

bors commented Oct 2, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 2, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2020
@bors

bors commented Oct 2, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f9d7720 with merge 4dedf5e...

@bors

bors commented Oct 2, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 4dedf5e to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2020
@bors
bors merged commit 4dedf5e into rust-lang:masterOct 2, 2020
@rustbotrustbot added this to the 1.48.0 milestone Oct 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@wesleywiser@oli-obk@bors@rust-highfive@rustbot