Uh oh!
There was an error while loading. Please reload this page.
Add word wrap for short descriptions - #77699
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
jyn514
commented
Oct 9, 2020
Member
Will this affect word-wrapping in paragraphs with longer text? I saw there was some undesired behavior in rust-lang/blog.rust-lang.org#508 (comment), will that show up here? |
jyn514
commented
Oct 9, 2020
Member
r? @XAMPPRocky I don't feel comfortable reviewing this, I don't know enough about CSS. |
Uh oh!
There was an error while loading. Please reload this page.
XAMPPRocky
commented
Oct 10, 2020
Contributor
@jyn514 This should be fine as it mostly just affects really long string of characters, most words won’t be broken up unless you set it to |
GuillaumeGomezforce-pushed
the
word-wrap
branch
from
October 12, 2020 13:41
7ab5583 to
9f1048dComparejyn514
reviewed
Oct 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
jyn514
commented
Oct 12, 2020
Member
@bors r=XAMPPRocky This seems reasonable; not sure I understand everything it does but it seems better than the status quo. |
bors
commented
Oct 12, 2020
Collaborator
📌 Commit 9f1048d has been approved by |
GuillaumeGomez
commented
Oct 12, 2020
MemberAuthor
@bors: rollup |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2020
Add word wrap for short descriptions Fixesrust-lang#77652  cc @WaffleLapkin r? @jyn514
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 12, 2020
Add word wrap for short descriptions Fixesrust-lang#77652  cc @WaffleLapkin r? @jyn514
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#77550 (add shims for WithOptConstParam query calls) - rust-lang#77699 (Add word wrap for short descriptions) - rust-lang#77724 (Implement `AsRawFd` for `StdinLock` etc. on WASI.) - rust-lang#77746 (Fix `x.py setup` sets `changelog-seen`) - rust-lang#77784 (Fix intra-docs link in core::ffi::VaList) - rust-lang#77811 (rustdoc: Make some functions private that don't need to be public) - rust-lang#77818 (Mono collector: replace pair of ints with Range) - rust-lang#77831 (Use std methods on char instead of open coding them) - rust-lang#77852 (update url in bootstrap README (gcc-rs -> cc-rs)) - rust-lang#77863 (Remove `mark-i-m` from rustc-dev-guide maintainers) Failed merges: r? `@ghost`
notriddle added a commit
to notriddle/rust
that referenced
this pull request
Dec 23, 2022
The rules `overflow:hidden` and `text-overflow:ellipses` only have an effect if overflow occurs, which cannot happen because it will just line wrap instead. These rules definitely became obsolete by rust-lang#77699, when the stylesheet was decidedly changed to have line wrapping in short docblocks, but given the bug it was fixing, this probably got broken earlier.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 23, 2022
…-overflow, r=GuillaumeGomez rustdoc: remove no-op CSS from `.docblock-short` The rules `overflow:hidden` and `text-overflow:ellipses` only have an effect if overflow occurs, which cannot happen because it will just line wrap instead. These rules definitely became obsolete by rust-lang#77699, when the stylesheet was decidedly changed to have line wrapping in short docblocks, but given the bug it was fixing, this probably got broken earlier.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 23, 2022
…-overflow, r=GuillaumeGomez rustdoc: remove no-op CSS from `.docblock-short` The rules `overflow:hidden` and `text-overflow:ellipses` only have an effect if overflow occurs, which cannot happen because it will just line wrap instead. These rules definitely became obsolete by rust-lang#77699, when the stylesheet was decidedly changed to have line wrapping in short docblocks, but given the bug it was fixing, this probably got broken earlier.
RalfJung pushed a commit
to RalfJung/miri
that referenced
this pull request
Dec 24, 2022
…, r=GuillaumeGomez rustdoc: remove no-op CSS from `.docblock-short` The rules `overflow:hidden` and `text-overflow:ellipses` only have an effect if overflow occurs, which cannot happen because it will just line wrap instead. These rules definitely became obsolete by rust-lang/rust#77699, when the stylesheet was decidedly changed to have line wrapping in short docblocks, but given the bug it was fixing, this probably got broken earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#77652
cc @WaffleLapkin
r? @jyn514