Skip to content

rustdoc: Make some functions private that don't need to be public - #77811

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:private
Oct 12, 2020
Merged

rustdoc: Make some functions private that don't need to be public#77811
bors merged 1 commit into
rust-lang:masterfrom
jyn514:private

Conversation

@jyn514

@jyn514jyn514 commented Oct 11, 2020

Copy link
Copy Markdown
Member

@jyn514jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 11, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2020
@jyn514

jyn514 commented Oct 11, 2020

Copy link
Copy Markdown
MemberAuthor

LMK if I should remove the debug!, I added it while looking at #77763.

GuillaumeGomez
GuillaumeGomez reviewed Oct 11, 2020
View reviewed changes
Comment threadsrc/librustdoc/clean/utils.rs Outdated
@GuillaumeGomez

GuillaumeGomez commented Oct 11, 2020

Copy link
Copy Markdown
Member

Thanks!

@bors: r+ rollup

@bors

bors commented Oct 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 83c790f has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2020
@JohnTitor
Rollup merge ofrust-lang#77811- jyn514:private, r=GuillaumeGomez
7f4b363
rustdoc: Make some functions private that don't need to be public
r? @GuillaumeGomez
@JohnTitorJohnTitor mentioned this pull request Oct 12, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2020
@JohnTitor
Rollup merge ofrust-lang#77811- jyn514:private, r=GuillaumeGomez
2c9ff19
rustdoc: Make some functions private that don't need to be public
r? @GuillaumeGomez
@JohnTitorJohnTitor mentioned this pull request Oct 12, 2020
Closed
@JohnTitorJohnTitor mentioned this pull request Oct 12, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2020
@bors
Auto merge ofrust-lang#77867- JohnTitor:rollup-0odg1n4, r=JohnTitor
1678854
Rollup of 10 pull requests
Successful merges:
- rust-lang#77550 (add shims for WithOptConstParam query calls)
- rust-lang#77699 (Add word wrap for short descriptions)
- rust-lang#77724 (Implement `AsRawFd` for `StdinLock` etc. on WASI.)
- rust-lang#77746 (Fix `x.py setup` sets `changelog-seen`)
- rust-lang#77784 (Fix intra-docs link in core::ffi::VaList)
- rust-lang#77811 (rustdoc: Make some functions private that don't need to be public)
- rust-lang#77818 (Mono collector: replace pair of ints with Range)
- rust-lang#77831 (Use std methods on char instead of open coding them)
- rust-lang#77852 (update url in bootstrap README (gcc-rs -> cc-rs))
- rust-lang#77863 (Remove `mark-i-m` from rustc-dev-guide maintainers)
Failed merges:
r? `@ghost`
@bors
bors merged commit fe0d5b6 into rust-lang:masterOct 12, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 12, 2020
@jyn514
jyn514 deleted the private branch October 12, 2020 21:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez left review comments

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jyn514@GuillaumeGomez@bors@rust-highfive@rustbot