Uh oh!
There was an error while loading. Please reload this page.
Remove needless alloc_slice - #77936
Merged
Merged
Conversation
Don't invoke alloc_slice. Arenas are temporary, empty slices are eternal!
rust-highfive
commented
Oct 14, 2020
Contributor
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
jonas-schievink
commented
Oct 14, 2020
Contributor
@bors r+ rollup |
bors
commented
Oct 14, 2020
Collaborator
📌 Commit 3019074 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#77570 (Allow ascii whitespace char for doc aliases ) - rust-lang#77739 (Remove unused code) - rust-lang#77753 (Check html comments) - rust-lang#77879 (Provide better documentation and help messages for x.py setup) - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) - rust-lang#77934 (Document -Z codegen-backend in the unstable book) - rust-lang#77936 (Remove needless alloc_slice) - rust-lang#77946 (Validate references to source scopes) - rust-lang#77951 (Update books) Failed merges: r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't invoke alloc_slice.
Arenas are temporary,
empty slices are eternal!