Include aarch64-pc-windows-msvc in the dist manifests by arlosi · Pull Request #77902 · rust-lang/rust

arlosi · 2020-10-13T15:48:07Z

r? @ehuss

/cc @pietroalbini @Mark-Simulacrum

#72881

ehuss · 2020-10-13T16:08:23Z

@bors r+ rollup

bors · 2020-10-13T16:08:25Z

📌 Commit 401f7b9a29f451c59ccca4f337b7ede7c59576e4 has been approved by ehuss

Alovchin91

~~Doesn't it need to be included in TARGETS as well?~~
nevermind, missed it 😅

Alovchin91 · 2020-10-13T18:49:21Z

@arlosi Looks like it conflicted with #77895 and failed to merge into a rollup. Sigh 😞 Is there a way to fix this, or it should wait for the next rollup (and thus won't get into tomorrow's nightly)?

arlosi · 2020-10-13T19:04:32Z

I think we just need to wait for the rollup to complete and resolve the conflict.

Rollup of 14 pull requests Successful merges: - rust-lang#77239 (Enable building Cargo for aarch64-apple-darwin) - rust-lang#77569 (BTreeMap: type-specific variants of node_as_mut and cast_unchecked) - rust-lang#77719 (Remove unnecessary rustc_const_stable attributes.) - rust-lang#77722 (Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).) - rust-lang#77725 (Add regression issue template) - rust-lang#77776 ( Give an error when running `x.py test --stage 0 src/test/ui`) - rust-lang#77786 (Mention rustdoc in `x.py setup`) - rust-lang#77825 (`min_const_generics` diagnostics improvements) - rust-lang#77868 (Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component) - rust-lang#77884 (Use Option::unwrap_or instead of open-coding it) - rust-lang#77886 (Replace trivial bool matches with the `matches!` macro) - rust-lang#77892 (Replace absolute paths with relative ones) - rust-lang#77895 (Include aarch64-apple-darwin in the dist manifests) - rust-lang#77909 (bootstrap: set correct path for the build-manifest binary) Failed merges: - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) r? `@ghost`

bors · 2020-10-14T00:59:15Z

☔ The latest upstream changes (presumably #77917) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

arlosi · 2020-10-14T02:03:52Z

Resolve conflicts.

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author
r? @ehuss

Rollup of 8 pull requests Successful merges: - rust-lang#77765 (Add LLVM flags to limit DWARF version to 2 on BSD) - rust-lang#77788 (BTreeMap: fix gdb provider on BTreeMap with ZST keys or values) - rust-lang#77795 (Codegen backend interface refactor) - rust-lang#77808 (Moved the main `impl` for FnCtxt to its own file.) - rust-lang#77817 (Switch rustdoc from `clean::Stability` to `rustc_attr::Stability`) - rust-lang#77829 (bootstrap: only use compiler-builtins-c if they exist) - rust-lang#77870 (Use intra-doc links for links to module-level docs) - rust-lang#77897 (Move `Strip` into a separate rustdoc pass) Failed merges: - rust-lang#77879 (Provide better documentation and help messages for x.py setup) - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) r? `@ghost`

ehuss · 2020-10-14T02:50:40Z

@bors r+

bors · 2020-10-14T02:50:41Z

📌 Commit de4bcfd has been approved by ehuss

bors · 2020-10-14T05:03:19Z

⌛ Testing commit de4bcfd with merge d5dd4442627a55d3d5135b6e554e22cacf46a1a6...

bors · 2020-10-14T05:26:34Z

💔 Test failed - checks-actions

ehuss · 2020-10-14T06:06:21Z

@bors retry

error inflating zlib stream; class=Zlib (5)
rust-lang/cargo#8517

bors · 2020-10-14T06:06:31Z

⌛ Testing commit de4bcfd with merge f0bfe8a3efec7fa740389732d02f986472aac2fa...

bors · 2020-10-14T06:26:14Z

💔 Test failed - checks-actions

emilyalbini · 2020-10-14T09:03:34Z

@bors retry

Spurious network failure.

bors · 2020-10-14T09:03:45Z

⌛ Testing commit de4bcfd with merge b517b2362ffabc768f54cd11e1715eb8ffddd4e1...

bors · 2020-10-14T13:18:45Z

💥 Test timed out

rust-log-analyzer · 2020-10-14T13:27:23Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[group]Run exit 1
exit 1
shell: /bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
##[error]Process completed with exit code 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

ehuss · 2020-10-14T14:23:44Z

@bors retry
4+ hour mac build

Alovchin91 · 2020-10-14T20:30:52Z

Is there a known issue with the pipeline, or is it just such an unlucky PR? 😐 Could a rebase help maybe?

ehuss · 2020-10-14T20:42:46Z

Nah, just a string of bad luck. It should get merged soon.

I'm working on fixing rust-lang/cargo#8517, but that will take at least a few days.
GitHub updated the macOS image which broke the CI, and that will be fixed via #77944.
The 4 hour thing is just random, and there's not much we can do about it. We think it is usually due to "noisy neighbors", or some other infrastructure problem out of our control.

Alovchin91 · 2020-10-14T22:13:50Z

Thanks for the detailed explanation! So I guess after #77944 has been merged the only thing we can do is keep trying? Oh well, those flaky CIs 😅

Rollup of 9 pull requests Successful merges: - rust-lang#77570 (Allow ascii whitespace char for doc aliases ) - rust-lang#77739 (Remove unused code) - rust-lang#77753 (Check html comments) - rust-lang#77879 (Provide better documentation and help messages for x.py setup) - rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests) - rust-lang#77934 (Document -Z codegen-backend in the unstable book) - rust-lang#77936 (Remove needless alloc_slice) - rust-lang#77946 (Validate references to source scopes) - rust-lang#77951 (Update books) Failed merges: r? `@ghost`

rust-highfive assigned ehuss Oct 13, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2020

Alovchin91 reviewed Oct 13, 2020
View reviewed changes

JohnTitor mentioned this pull request Oct 13, 2020
Rollup of 10 pull requests #77904
Closed

JohnTitor mentioned this pull request Oct 13, 2020
Rollup of 14 pull requests #77917
Merged

Dylan-DPC-zz mentioned this pull request Oct 14, 2020
Rollup of 8 pull requests #77926
Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2020

Include aarch64-pc-windows-msvc in the dist manifests
de4bcfd

arlosi force-pushed the arm64manifest branch from 401f7b9 to de4bcfdCompare October 14, 2020 02:03

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020

JohnTitor mentioned this pull request Oct 14, 2020
Rollup of 9 pull requests #77954
Merged

bors merged commit b3f9512 into rust-lang:masterOct 15, 2020

rustbot added this to the 1.49.0 milestone Oct 15, 2020

ZHOUYue67 mentioned this pull request Oct 31, 2020
Rust supports Windows on Arm dstaley/is-windows-on-arm-ready#4
Merged

Uh oh!

Uh oh!

Conversation

arlosi commented Oct 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ehuss commented Oct 13, 2020

Uh oh!

bors commented Oct 13, 2020

Uh oh!

Alovchin91 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alovchin91 commented Oct 13, 2020

Uh oh!

arlosi commented Oct 13, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

arlosi commented Oct 14, 2020

Uh oh!

ehuss commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

ehuss commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

emilyalbini commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

bors commented Oct 14, 2020

Uh oh!

rust-log-analyzer commented Oct 14, 2020

Uh oh!

ehuss commented Oct 14, 2020

Uh oh!

Alovchin91 commented Oct 14, 2020

Uh oh!

ehuss commented Oct 14, 2020

Uh oh!

Alovchin91 commented Oct 14, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

arlosi commented Oct 13, 2020•
edited
Loading

Alovchin91 left a comment •
edited
Loading

Alovchin91 commented Oct 14, 2020•
edited
Loading