Skip to content

Add cg_clif as optional codegen backend - #77975

Merged
bors merged 1724 commits into
rust-lang:masterfrom
bjorn3:cg_clif_subtree3
Oct 26, 2020
Merged

Add cg_clif as optional codegen backend#77975
bors merged 1724 commits into
rust-lang:masterfrom
bjorn3:cg_clif_subtree3

Conversation

@bjorn3

@bjorn3bjorn3 commented Oct 15, 2020

Copy link
Copy Markdown
Member

Rustc_codegen_cranelift is an alternative codegen backend for rustc based on Cranelift. It has the potential to improve compilation times in debug mode. In my experience the compile time improvements over debug mode LLVM for a clean build are about 20-30% in most cases.

This PR adds cg_clif as optional codegen backend. By default it is only enabled for ./x.py check. It can be enabled for ./x.py build too by adding cranelift to the rust.codegen-backends array in config.toml.

MCP: rust-lang/compiler-team#270

r? @Mark-Simulacrum

bjorn3and others added 30 commits June 16, 2020 11:02
@bjorn3
[CI] Run the compile step with CARGO_INCREMENTAL=1
af0fa74
@bjorn3
Revert "[CI] Run the compile step with CARGO_INCREMENTAL=1"
b614448
This reverts commit af0fa74.
It didn't do anything
@bjorn3
Some changes necessary for Windows support
daad966
cc rust-lang#977
@bjorn3
Only run ranlib when necessary
282e305
@bjorn3
Make mini_core_hello_world work on Windows once TLS is supported
d4187e6
@bjorn3
Only call build_value_labels_ranges when necessary
3086e44
@bjorn3
Rustup to rustc 1.46.0-nightly (2d8bd9b2020-06-19)
266ca93
@bjorn3
Update Cranelift
b4d9d8a
@bjorn3
Ignore libcore test that requires unwinding support
f718378
@bjorn3
Implement #[link_section]
5c6bf83
Fixesrust-lang#1047
@bjorn3
Use Cranelift legalization for icmp.i128
ef4186a
The previous translation was wrong for signed 128bit comparisions
This fixes several libcore tests
@bjorn3
Unignore some more libcore tests
177348f
@bjorn3
Implement checked_mul
5f54cc7
Fixes#6
@bjorn3
Ignore less of the libcore float tests
392348d
@bjorn3
Introduce #[cfg(target_feature = "cg_clif")]
431cebd
@bjorn3
Prelude cleanup
eb8fd19
@bjorn3
Warn on unsupported pass modes for extern "C"
fc5e583
cc rust-lang#10
@bjorn3
Disable "LTO is not supported" warning for sysroot build
b79102c
@bjorn3
Simplify assert_assignable
9c0d18c
Assignments are no longer used to implicitly cast between &mut T and &T
@bjorn3
Prevent different vtables with the same name
1f3dd4f
Fixesrust-lang#987
@bjorn3
Rustup to rustc 1.46.0-nightly (6bb3dbf2020-06-22)
f77fab8
@bjorn3
Remove leftover of removed hack
98c83d2
@bjorn3
Don't perform a double substitution in some cases
a3cd293
@vi@bjorn3
Longer README about how to use this instead ofcargo run(rust-lang…
eda840a
…#1054)
* Longer README about how to use this instead of `cargo run`
Resolvesrust-lang#1052.
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
@bjorn3
Add goal and better current status to readme
58ffc47
@bjorn3
Rustup to rustc 1.46.0-nightly (7750c3d2020-06-26)
48d4bc2
@bjorn3
Update Cranelift
ef92432
@bjorn3
Update dependencies
4bfc4a1
@bjorn3
Don't use a 1-to-1 mapping between mir local and cranelift_frontend v…
3227203
…ariable
@bjorn3
Rustup to rustc 1.46.0-nightly (0ca7f742020-06-29)
57d9dda
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Oct 26, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup=never p=5

@bors

bors commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit ac4f7de has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2020
@bors

bors commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ac4f7de with merge 35debd4...

@bors

bors commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 35debd4 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2020
@bors
bors merged commit 35debd4 into rust-lang:masterOct 26, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 26, 2020
@bjorn3
bjorn3 deleted the cg_clif_subtree3 branch October 26, 2020 18:51
This was referenced Oct 26, 2020
Merged
Merged
This was referenced Nov 1, 2020
Merged
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 3, 2020
@Dylan-DPC
Rollup merge ofrust-lang#78624- bjorn3:update_cg_clif-2020-11-01, r…
da3091b
…=jyn514
Sync rustc_codegen_cranelift
This fixes bootstrapping of rustc using cg_clif again. It regressed a while before rust-lang#77975 got merged.
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/743
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 3, 2020
@m-ou-se
Rollup merge ofrust-lang#78624- bjorn3:update_cg_clif-2020-11-01, r…
39f5563
…=jyn514
Sync rustc_codegen_cranelift
This fixes bootstrapping of rustc using cg_clif again. It regressed a while before rust-lang#77975 got merged.
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/743
@bjorn3bjorn3 mentioned this pull request Nov 10, 2020
Merged
@jonas-schievink

jonas-schievink commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

I think this has broken -Cpasses=list, which is now empty, as well as the LLVM version output in rustc -Vv, which is now missing

@bjorn3

bjorn3 commented Jan 13, 2021

Copy link
Copy Markdown
MemberAuthor

Oops. I used cfg!(llvm) instead of cfg!(feature = "llvm") for those.

@bjorn3bjorn3 mentioned this pull request Jan 13, 2021
Merged
@bjorn3

bjorn3 commented Jan 13, 2021

Copy link
Copy Markdown
MemberAuthor

Opened #80981

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 14, 2021
@JohnTitor
Rollup merge ofrust-lang#80981- bjorn3:bjorn3-patch-1, r=jonas-schi…
87f94f2
…evink
Fix -Cpasses=list and llvm version print with -vV
cc rust-lang#77975 (comment)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 14, 2021
@JohnTitor
Rollup merge ofrust-lang#80981- bjorn3:bjorn3-patch-1, r=jonas-schi…
70f5725
…evink
Fix -Cpasses=list and llvm version print with -vV
cc rust-lang#77975 (comment)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 14, 2021
@JohnTitor
Rollup merge ofrust-lang#80981- bjorn3:bjorn3-patch-1, r=jonas-schi…
30ec4de
…evink
Fix -Cpasses=list and llvm version print with -vV
cc rust-lang#77975 (comment)
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jan 14, 2021
@m-ou-se
Rollup merge ofrust-lang#80981- bjorn3:bjorn3-patch-1, r=jonas-schi…
459b274
…evink
Fix -Cpasses=list and llvm version print with -vV
cc rust-lang#77975 (comment)
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jan 14, 2021
@m-ou-se
Rollup merge ofrust-lang#80981- bjorn3:bjorn3-patch-1, r=jonas-schi…
ce3bc76
…evink
Fix -Cpasses=list and llvm version print with -vV
cc rust-lang#77975 (comment)
@osa1osa1 mentioned this pull request Feb 13, 2021
Closed
@LeSeulArtichautLeSeulArtichaut added the A-cranelift Things relevant to the [future] cranelift backend label Jul 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

A-craneliftThings relevant to the [future] cranelift backendmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

15 participants

@bjorn3@Mark-Simulacrum@est31@bors@jonas-schievink@rust-highfive@LeSeulArtichaut@rustbot@vi@spastorino@Veetaha@craigmayhew@CohenArthur@mbrubeck@l4l