Uh oh!
There was an error while loading. Please reload this page.
Upgrade dlmalloc to version 0.2 - #78138
Merged
Merged
Conversation
rust-highfive
commented
Oct 20, 2020
Contributor
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
raoulstrackx
commented
Nov 6, 2020
ContributorAuthor
Blocked by alexcrichton/dlmalloc-rs#15 |
raoulstrackxforce-pushed
the
raoul/dlmalloc0.2
branch
from
November 9, 2020 17:27
74359f7 to
26f0f12Compareraoulstrackx
commented
Nov 10, 2020
ContributorAuthor
Could this get a review please? |
Mark-Simulacrum
commented
Nov 10, 2020
Member
@bors r+ |
bors
commented
Nov 10, 2020
Collaborator
📌 Commit 26f0f12 has been approved by |
This was referenced Nov 11, 2020
jonas-schievink
commented
Nov 11, 2020
Contributor
@bors r- rollup=iffy failed in #78954 (comment) |
raoulstrackxforce-pushed
the
raoul/dlmalloc0.2
branch
from
November 12, 2020 20:41
26f0f12 to
292f15cCompareraoulstrackx
commented
Nov 13, 2020
ContributorAuthor
@Mark-Simulacrum I've fixed support for Wasm. Could you review the PR again? Thanks! |
shepmaster
commented
Nov 17, 2020
Member
Mark-Simulacrum
commented
Nov 17, 2020
Member
@bors r+ |
bors
commented
Nov 17, 2020
Collaborator
📌 Commit 292f15c has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#77939 (Ensure that the source code display is working with DOS backline) - rust-lang#78138 (Upgrade dlmalloc to version 0.2) - rust-lang#78967 (Make codegen tests compatible with extra inlining) - rust-lang#79027 (Limit storage duration of inlined always live locals) - rust-lang#79077 (document that __rust_alloc is also magic to our LLVM fork) - rust-lang#79088 (clarify `span_label` documentation) - rust-lang#79097 (Code block invalid html tag lint) - rust-lang#79105 (std: Fix test `symlink_hard_link` on Windows) - rust-lang#79107 (build-manifest: strip newline from rustc version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation of adding dynamic memory management support for SGXv2-enabled platforms, the dlmalloc crate has been refactored. More specifically, support has been added to implement platform specification outside of the dlmalloc crate. (see alexcrichton/dlmalloc-rs#15)
This PR upgrades dlmalloc to version 0.2 for the
wasmandsgxtargets.As the dlmalloc changes have received a positive review, but have not been merged yet, this PR contains a commit to prevent tidy from aborting CI prematurely.
cc: @jethrogb