Skip to content

clarify span_label documentation - #79088

Merged
bors merged 1 commit into
rust-lang:masterfrom
euclio:span-label-doc
Nov 17, 2020
Merged

clarify span_label documentation#79088
bors merged 1 commit into
rust-lang:masterfrom
euclio:span-label-doc

Conversation

@euclio

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2020
Comment threadcompiler/rustc_errors/src/diagnostic_builder.rs Outdated
Comment threadcompiler/rustc_errors/src/diagnostic_builder.rs Outdated
@estebank

Copy link
Copy Markdown
Contributor

r=me after addressing @RalfJung's comments.

@euclio

Copy link
Copy Markdown
ContributorAuthor

Updated.

@estebank

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 17, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit a78966d has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 17, 2020
clarify `span_label` documentation
Fixesrust-lang#71857.
r? `@estebank`
cc `@RalfJung`
@m-ou-sem-ou-se mentioned this pull request Nov 17, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2020
Rollup of 9 pull requests
Successful merges:
- rust-lang#77939 (Ensure that the source code display is working with DOS backline)
- rust-lang#78138 (Upgrade dlmalloc to version 0.2)
- rust-lang#78967 (Make codegen tests compatible with extra inlining)
- rust-lang#79027 (Limit storage duration of inlined always live locals)
- rust-lang#79077 (document that __rust_alloc is also magic to our LLVM fork)
- rust-lang#79088 (clarify `span_label` documentation)
- rust-lang#79097 (Code block invalid html tag lint)
- rust-lang#79105 (std: Fix test `symlink_hard_link` on Windows)
- rust-lang#79107 (build-manifest: strip newline from rustc version)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c459ab3 into rust-lang:masterNov 17, 2020
@rustbotrustbot added this to the 1.50.0 milestone Nov 17, 2020
@euclio
euclio deleted the span-label-doc branch November 22, 2020 16:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DiagnosticBuilder::span_label (sometimes?) does nothing

6 participants

@euclio@estebank@bors@RalfJung@rust-highfive@rustbot