Add Sized trait display when implemented on type by GuillaumeGomez · Pull Request #78181 · rust-lang/rust

GuillaumeGomez · 2020-10-21T12:24:26Z

Fixes#24183.

I'm not too happy about the hack I had to add in here, however, it seems like the Sized trait is very special.

cc @jyn514
r? @ollie27

jyn514 · 2020-10-30T06:42:55Z

Oops, looks like triagebot got confused. @GuillaumeGomez I think you need to put cc after the r??

r? @ollie27

GuillaumeGomez · 2020-11-01T20:11:33Z

ping

GuillaumeGomez · 2020-12-04T13:48:34Z

Ok, seems to be ready!

JohnCSimon · 2021-02-14T17:09:19Z

triage: merge conflict

@rustbot label: -S-waiting-on-review +S-waiting-on-author

GuillaumeGomez · 2021-02-14T17:10:42Z

It's still waiting for a review.

@rustbot label: -S-waiting-on-author +S-waiting-on-review

GuillaumeGomez · 2021-02-18T19:47:41Z

It now only displays in case the Sized trait isn't implemented.

jyn514

Note this will have major conflicts with #82020, so you may want to wait to work on it more until that's merged.

GuillaumeGomez · 2021-02-19T21:09:45Z

Updated!

jyn514

This looks good :) r=me with nit fixed, it took me a second to understand the code the first time.

GuillaumeGomez · 2021-02-19T21:38:48Z

it took me a second to understand the code the first time.

Oh sorry, I tried to make the parameter name as explicit as possible but I realize that some comments would have make it much better. I added another one in addition to the one you suggested. :)

GuillaumeGomez · 2021-02-19T22:54:59Z

@bors: r=jyn514

bors · 2021-02-19T22:55:00Z

📌 Commit 46f24c9 has been approved by jyn514

Add Sized trait display when implemented on type Fixesrust-lang#24183. I'm not too happy about the hack I had to add in here, however, it seems like the `Sized` trait is **very** special. cc `@jyn514` r? `@ollie27`

bors · 2021-02-20T04:36:03Z

⌛ Testing commit 46f24c9 with merge b75baad...

bors · 2021-02-20T07:31:36Z

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing b75baad to master...

rust-log-analyzer · 2021-02-20T07:32:53Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

 CACHE_DOMAIN: ci-caches.rust-lang.org
TOOLSTATE_REPO_ACCESS_TOKEN: ***
##[endgroup]
Cloning into 'rust-toolstate'...
/home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: 'U' mode is deprecated
📣 Toolstate changed by rust-lang/rust#78181!
Tested on commit rust-lang/rust@b75baad5c3fcb85676c4df648962e53c9756e7ba.
Direct link to PR: <https://github.com/rust-lang/rust/pull/78181>
💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung @eddyb).
with open(path, 'rU') as f:
Traceback (most recent call last):
File "/home/runner/work/rust/rust/src/tools/publish_toolstate.py", line 338, in <module>
response = urllib2.urlopen(urllib2.Request(
File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python3.8/urllib/request.py", line 522, in open
req = meth(req)
File "/usr/lib/python3.8/urllib/request.py", line 1281, in do_request_
raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
##[error]Process completed with exit code 1.

rust-highfive assigned jyn514 Oct 21, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2020

GuillaumeGomez force-pushed the sized-trait branch from 126945d to 2f8ab71Compare October 21, 2020 13:36

jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 22, 2020

rust-highfive assigned ollie27 and unassigned jyn514 Oct 30, 2020

This comment has been minimized.
Sign in to view

GuillaumeGomez force-pushed the sized-trait branch from 2f8ab71 to 3975705Compare November 15, 2020 20:05

jyn514 reviewed Nov 15, 2020
View reviewed changes

Comment threadsrc/librustdoc/clean/auto_trait.rs Outdated
Comment threadsrc/test/rustdoc/empty-section.rs Outdated

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2020

GuillaumeGomez force-pushed the sized-trait branch 2 times, most recently from ab48efc to 56a60eaCompare December 4, 2020 12:50

This comment has been minimized.
Sign in to view

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2021

GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2021

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2021

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2021

jyn514 reviewed Feb 14, 2021
View reviewed changes

Comment threadsrc/test/rustdoc/sized_trait.rs Outdated

jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2021

GuillaumeGomez force-pushed the sized-trait branch from 56a60ea to 877f197Compare February 18, 2021 19:47

jyn514 reviewed Feb 18, 2021
View reviewed changes

Comment threadsrc/librustdoc/clean/auto_trait.rs Outdated
Comment threadsrc/librustdoc/core.rs Outdated
Comment threadsrc/librustdoc/core.rs Outdated

This comment has been minimized.
Sign in to view

GuillaumeGomez force-pushed the sized-trait branch 2 times, most recently from 4abb66d to fbc8c70Compare February 19, 2021 21:09

jyn514 reviewed Feb 19, 2021
View reviewed changes

Comment threadsrc/librustdoc/clean/auto_trait.rs Outdated

GuillaumeGomez force-pushed the sized-trait branch from fbc8c70 to 5fd3b9aCompare February 19, 2021 21:37

GuillaumeGomez added 2 commits February 19, 2021 22:38

Show negative implementation of Sized trait
d20e05b

Add tests for !Sized trait display
46f24c9

GuillaumeGomez force-pushed the sized-trait branch from 5fd3b9a to 46f24c9Compare February 19, 2021 21:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2021

GuillaumeGomez mentioned this pull request Feb 19, 2021
Rollup of 4 pull requests #82306
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 20, 2021

bors merged commit b75baad into rust-lang:masterFeb 20, 2021

rustbot added this to the 1.52.0 milestone Feb 20, 2021

bors mentioned this pull request Feb 20, 2021
Calculate span info on-demand #80339
Merged

GuillaumeGomez deleted the sized-trait branch February 20, 2021 13:22

jyn514 mentioned this pull request Mar 30, 2021
rustdoc: Self: Sized bounds in different crates are pruned #24183
Closed

fmease mentioned this pull request Nov 30, 2025
rustdoc doesn't render non-trivial built-in Sized impls (and calls Sized impls auto trait impls) #149467
Open

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Oct 21, 2020• edited by jyn514 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jyn514 commented Oct 30, 2020

Uh oh!

GuillaumeGomez commented Nov 1, 2020

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

GuillaumeGomez commented Dec 4, 2020

Uh oh!

This comment has been minimized.

JohnCSimon commented Feb 14, 2021

Uh oh!

GuillaumeGomez commented Feb 14, 2021

Uh oh!

Uh oh!

GuillaumeGomez commented Feb 18, 2021

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Feb 19, 2021

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GuillaumeGomez commented Feb 19, 2021

Uh oh!

GuillaumeGomez commented Feb 19, 2021

Uh oh!

bors commented Feb 19, 2021

Uh oh!

bors commented Feb 20, 2021

Uh oh!

bors commented Feb 20, 2021

Uh oh!

rust-log-analyzer commented Feb 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

GuillaumeGomez commented Oct 21, 2020•
edited by jyn514
Loading