Uh oh!
There was an error while loading. Please reload this page.
Rollup of 4 pull requests - #82306
Closed
GuillaumeGomez wants to merge 12 commits into
Closed
Conversation
Stdin uses handle whereas StdinLock uses stdin_lock, changed it to handle.
It's not possible to check if removing a semicolon fixes the type error when checking match arms and one or both of the last arm's and the current arm's return types are imported "opaque" types. In these cases we don't generate a "consider removing semicolon" suggestions. Fixesrust-lang#81839
The feature was stabilized in rust-lang#66172, but the usage string was not updated to be shown. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Add Sized trait display when implemented on type Fixesrust-lang#24183. I'm not too happy about the hack I had to add in here, however, it seems like the `Sized` trait is **very** special. cc `@jyn514` r? `@ollie27`
Fix panic in 'remove semicolon' when types are not local It's not possible to check if removing a semicolon fixes the type error when checking match arms and one or both of the last arm's and the current arm's return types are imported "opaque" types. In these cases we don't generate a "consider removing semicolon" suggestions. Fixesrust-lang#81839 --- I'm not sure how to add a test for this. I think the test would need at least two crates. Do we have any existing tests that do this so that I can take a look?
Keep consistency in example for Stdin StdinLock Stdin uses handle whereas StdinLock uses stdin_lock, changed it to handle.
rustc: Show `@path` usage in stable The feature was stabilized in rust-lang#66172, but the usage string was not updated to be shown.
GuillaumeGomez
commented
Feb 19, 2021
MemberAuthor
@bors: r+ p=4 |
bors
commented
Feb 19, 2021
Collaborator
📌 Commit 347b269 has been approved by |
bors
commented
Feb 20, 2021
Collaborator
⌛ Testing commit 347b269 with merge b27700940cd53e7ab79943aebc1400a423f81de7... |
bors
commented
Feb 20, 2021
Collaborator
💔 Test failed - checks-actions |
rust-log-analyzer
commented
Feb 20, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
@pathusage in stable #82260 (rustc: Show@pathusage in stable)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup