Skip to content

Exhaustively match in variant count instrinsic - #79231

Merged
bors merged 3 commits into
rust-lang:masterfrom
wusyong:issue-79137
Nov 21, 2020
Merged

Exhaustively match in variant count instrinsic#79231
bors merged 3 commits into
rust-lang:masterfrom
wusyong:issue-79137

Conversation

@wusyong

@wusyongwusyong commented Nov 20, 2020

Copy link
Copy Markdown

@rust-highfive

rust-highfive commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2020
lcnr
lcnr reviewed Nov 20, 2020
View reviewed changes
Comment threadcompiler/rustc_mir/src/interpret/intrinsics.rs Outdated
@lcnr

lcnr commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

r? @lcnr

@rust-highfiverust-highfive assigned lcnr and unassigned davidtwcoNov 20, 2020
lcnr
lcnr reviewed Nov 20, 2020
View reviewed changes
Comment threadsrc/test/ui/consts/issue-79137-toogeneric.rs Outdated
@lcnr

lcnr commented Nov 21, 2020

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit bc43380 has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Nov 21, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2020
@bors
Auto merge ofrust-lang#79273- Dylan-DPC:rollup-zd10xlt, r=Dylan-DPC
da38469
Rollup of 8 pull requests
Successful merges:
- rust-lang#77844 (clarify rules for ZST Boxes)
- rust-lang#79067 (Refactor the abi handling code a bit)
- rust-lang#79182 (Fix links to extern types in rustdoc (fixesrust-lang#78777))
- rust-lang#79231 (Exhaustively match in variant count instrinsic)
- rust-lang#79238 (Direct RUSTC_LOG (tracing/log) output to stderr instead of stdout.)
- rust-lang#79256 (Fix typos)
- rust-lang#79264 (Get rid of some doctree items)
- rust-lang#79272 (Support building clone shims for arrays with generic size)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit bb73ea6 into rust-lang:masterNov 21, 2020
@rustbotrustbot added this to the 1.50.0 milestone Nov 21, 2020
@wusyong
wusyong deleted the issue-79137 branch November 22, 2020 06:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

variant_count intrinsic is evaluated incorrectly in generic code

6 participants

@wusyong@rust-highfive@lcnr@bors@davidtwco@rustbot