Uh oh!
There was an error while loading. Please reload this page.
Get rid of some doctree items - #79264
Merged
Merged
Conversation
jyn514force-pushed
the
less-doctree
branch
3 times, most recently
from
November 21, 2020 14:35
0b8f21a to
5f602cdCompareGuillaumeGomez
commented
Nov 21, 2020
Member
You took my advice! \o/ Code looks good so if you intend to work on it incrementally and intend to merge this PR as is, then r=me. :) |
jyn514
commented
Nov 21, 2020
MemberAuthor
bors
commented
Nov 21, 2020
Collaborator
📌 Commit 5f602cda5120cd02126a252fc1775f5bb5a4c56c has been approved by |
jyn514
commented
Nov 21, 2020
MemberAuthor
They can be derived directly from the `hir::Item`, there's no special logic. - TypeDef - OpaqueTy - Constant - Static - TraitAlias - Enum - Union - Struct
jyn514
commented
Nov 21, 2020
MemberAuthor
@bors r=guillaumegomez I fixed the names when inlining and also converted |
bors
commented
Nov 21, 2020
Collaborator
📌 Commit 7888406 has been approved by |
jyn514
commented
Nov 21, 2020
MemberAuthor
@bors r- Ugh, apparently some of the tests depend on the order errors are emitted. |
jyn514
commented
Nov 21, 2020
MemberAuthor
@bors r=GuillaumeGomez |
bors
commented
Nov 21, 2020
Collaborator
📌 Commit e280ae8 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 21, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#77844 (clarify rules for ZST Boxes) - rust-lang#79067 (Refactor the abi handling code a bit) - rust-lang#79182 (Fix links to extern types in rustdoc (fixesrust-lang#78777)) - rust-lang#79231 (Exhaustively match in variant count instrinsic) - rust-lang#79238 (Direct RUSTC_LOG (tracing/log) output to stderr instead of stdout.) - rust-lang#79256 (Fix typos) - rust-lang#79264 (Get rid of some doctree items) - rust-lang#79272 (Support building clone shims for arrays with generic size) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Nov 22, 2020
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 24, 2020
Get rid of `doctree::Impl` Follow-up to rust-lang#79264, continues breaking up rust-lang#78082. At some point I want to introduce `MaybeInlined`, but I think I'll wait until I need `MaybeInlined::InlinedWithOriginal` because it's not very useful in other situations. r? `@GuillaumeGomez`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2020
Get rid of doctree::{ExternalCrate, ForeignItem, Trait, Function}
Closesrust-lang#79314, closesrust-lang#79331, closesrust-lang#79332. Follow-up to rust-lang#79264 and rust-lang#79312, continues breaking up rust-lang#78082.
r? `@GuillaumeGomez`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They can be derived directly from the
hir::Item, there's no special logic.Part of #78082 (the easiest part, I'm still debugging some other changes).
r? @GuillaumeGomez