Skip to content

Get rid of doctree::Function - #79331

Closed
jyn514 wants to merge 3 commits into
rust-lang:masterfrom
jyn514:doctree-fn
Closed

Get rid of doctree::Function#79331
jyn514 wants to merge 3 commits into
rust-lang:masterfrom
jyn514:doctree-fn

Conversation

@jyn514

Copy link
Copy Markdown
Member

Builds on #79312 and #79314 and should not be merged before. Follow-up to #79264, continues breaking up #78082.

@GuillaumeGomez let me know if these would be easier to review as one PR - they're fairly independent, I just don't want to keep rebasing over the conflicts because git isn't smart.

r? @GuillaumeGomez

@jyn514jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 23, 2020
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2020
@bors

bors commented Nov 24, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #79377) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@borsbors closed this in 25a6910Nov 24, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jyn514@bors@GuillaumeGomez@rust-highfive