Skip to content

Add Box::into_inner. - #80438

Merged
bors merged 1 commit into
rust-lang:masterfrom
crlf0710:box_into_inner
Feb 10, 2021
Merged

Add Box::into_inner.#80438
bors merged 1 commit into
rust-lang:masterfrom
crlf0710:box_into_inner

Conversation

@crlf0710

@crlf0710crlf0710 commented Dec 28, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This adds a Box::into_inner method to the Box type. I actually suggest deprecating the compiler magic of *b if this gets stablized in the future.

r? @m-ou-se

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2020
@crlf0710crlf0710 mentioned this pull request Dec 28, 2020
Open
4 tasks
pickfire
pickfire reviewed Dec 28, 2020
View reviewed changes
Comment threadlibrary/alloc/src/boxed.rs Outdated
sugar700
sugar700 suggested changes Dec 28, 2020
View reviewed changes
Comment threadlibrary/alloc/src/boxed.rs Outdated
@sugar700

sugar700 commented Dec 28, 2020

Copy link
Copy Markdown
Contributor

Personally I would rather prefer to have DerefMove to allow other types to be special like Box, but that's just my opinion.

@fmease

fmease commented Dec 28, 2020

Copy link
Copy Markdown
Member

Should the documentation mention deref'ing the box as an alternative? This might prevent confusion.

jyn514
jyn514 reviewed Dec 28, 2020
View reviewed changes
Comment threadlibrary/alloc/src/boxed.rs Outdated
@camelidcamelid added T-lang Relevant to the language team T-libs-api [DEPRECATED; DO NOT USE] labels Dec 29, 2020
@m-ou-se

m-ou-se commented Dec 30, 2020

Copy link
Copy Markdown
Member

I actually suggest deprecating the compiler magic of *b if this gets stablized in the future.

That's a rather large change; one that should be discussed with the lang team first. Has there been any discussion on this? How about alternatives like a moving-out-of-deref trait as suggested above?

Without that language change, is there a good use case for this new function?

@m-ou-sem-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2020
@crlf0710

crlf0710 commented Dec 31, 2020

Copy link
Copy Markdown
MemberAuthor

@m-ou-se Yes, there is still a use case (which i think is good).
if i have a type S which is Copy and i have a Box<S> value, and i want to take the S value out.

#[derive(Copy,Clone,Debug)]structS;let boxed_val = Box::new(S);let val = *boxed_val;// this copies the value out (with Deref), but the memory is not deallocated.println!("{:?}", boxed_val);//it's still alive now, needs another `drop` to deallocate.// do something more.

This seems a footgun because the behavior of that line depends on whether S is Copy. With this function i can easily do what i want. A moving-out-of-deref trait won't be able to fix this.

(Deprecating the compiler magic of *b)
That's a rather large change; one that should be discussed with the lang team first.

Indeed! But i think whether or not that change will happen, this convenience function serves its purpose well. And there's already Pin::into_inner(and many others) in the standard library so this is not an inconsistent addition. And i'm only purposing adding it as an unstable method.

@crlf0710crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2020
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2021
@JohnCSimon

JohnCSimon commented Feb 7, 2021

Copy link
Copy Markdown

merge conflict
@JohnCSimon label: +S-waiting-on-author -S-waiting-on-author

m-ou-se
m-ou-se reviewed Feb 8, 2021
View reviewed changes
Comment threadlibrary/alloc/src/boxed.rs Outdated
@crlf0710

crlf0710 commented Feb 9, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased and squashed.

pickfire
pickfire reviewed Feb 9, 2021
View reviewed changes
Comment threadlibrary/alloc/src/boxed.rs
///
/// let c = Box::new(5);
///
/// assert_eq!(Box::into_inner(c), 5);

@pickfirepickfireFeb 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same as *c? Why is the deref bad and we want to remove it?

@m-ou-sem-ou-seFeb 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already discussed. See the conversation above.

@m-ou-se

m-ou-se commented Feb 9, 2021

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Feb 9, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit ce7de07 has been approved by m-ou-se

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2021
@JohnTitorJohnTitor mentioned this pull request Feb 10, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2021
@bors
Auto merge ofrust-lang#81952- JohnTitor:rollup-i28kgfb, r=JohnTitor
f7534b5
Rollup of 11 pull requests
Successful merges:
- rust-lang#79849 (Clarify docs regarding sleep of zero duration)
- rust-lang#80438 (Add `Box::into_inner`.)
- rust-lang#81466 (Add suggest mut method for loop)
- rust-lang#81687 (Make Vec::split_at_spare_mut public)
- rust-lang#81904 (Bump stabilization version for const int methods)
- rust-lang#81909 ([compiler/rustc_typeck/src/check/expr.rs] Remove unnecessary refs in pattern matching)
- rust-lang#81910 (Use format string in bootstrap panic instead of a string directly)
- rust-lang#81913 (Rename HIR UnOp variants)
- rust-lang#81925 (Add long explanation for E0547)
- rust-lang#81926 (add suggestion to use the `async_recursion` crate)
- rust-lang#81951 (Update cargo)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a28f2af into rust-lang:masterFeb 10, 2021
@rustbotrustbot added this to the 1.52.0 milestone Feb 10, 2021
@crlf0710
crlf0710 deleted the box_into_inner branch February 12, 2021 02:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-ou-sem-ou-sem-ou-se left review comments
+3 more reviewers
@pickfirepickfirepickfire left review comments
@jyn514jyn514jyn514 left review comments
@sugar700sugar700sugar700 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@m-ou-sem-ou-se

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-langRelevant to the language teamT-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.52.0

Development

Successfully merging this pull request may close these issues.

11 participants

@crlf0710@sugar700@fmease@m-ou-se@JohnCSimon@bors@pickfire@jyn514@rust-highfive@camelid@rustbot