Make symbols stripping work on MacOS X by calavera · Pull Request #82037 · rust-lang/rust

calavera · 2021-02-12T18:32:42Z

As reported in the stabilization issue, MacOS' linker doesn't support the -s and -S flags to strip symbols anymore. However, the os ships a separated tool to perform these operations.

This change allows the compiler to use that tool after a target has been compiled to strip symbols.

For rationale, see: #72110 (comment)
For option selection, see: https://www.unix.com/man-page/osx/1/strip/

Signed-off-by: David Calavera david.calavera@gmail.com

rust-highfive · 2021-02-12T18:32:45Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

calavera · 2021-02-25T23:31:03Z

@estebank can you let me know if this is a good direction to solve the problem on MacOS? I'll be happy to modify this patch as needed

eggyal · 2021-03-03T19:01:27Z

@petrochenkov perhaps this is one for your review, given that you were involved in #72110 and #73138?

estebank · 2021-03-03T22:42:22Z

I would feel better if someone with more understanding of codegen took over this PR. @petrochenkov or @ehuss, would you be up to it? The code itself looks reasonable, but this is not my area of expertise.

ehuss · 2021-03-08T18:26:58Z

@ehuss, would you be up to it?

Not really. I can help discuss it, but I don't have the time to be responsible here.

estebank · 2021-03-08T19:24:48Z

I really don't want to block on this, so I will send a blast to the rest of the team. @rust-lang/compiler would any of you be a better fit for reviewing this PR?

pnkfelix · 2021-03-11T15:47:52Z

self-assigning to act as extra eyeballs for @estebank . Un-nominating from team.

JohnCSimon · 2021-04-18T23:59:26Z

Ping from triage: @calavera can you please address the merge conflict? thank you

@rustbot label: -S-waiting-on-review +S-waiting-on-author

calavera · 2021-04-19T23:54:24Z

@JohnCSimon thanks for the ping. I've updated this PR.

calavera · 2021-04-22T23:39:01Z

@ehuss I've looked at adding another LinkerFlavor option, but I think it's going to over complicate this change.

That enum is used extensively to control other linker behaviors, much more important than this feature. Introducing an option that is not used like the rest of the flavors would only be more confusing for future contributors, in my opinion.

Moreover, there are other features that follow the same convention that I'm using here, which is checking the is_like_osx flag, and similar, to execute further commands for specific targets, see the stabilization PR for -Zrun-dsymutil as -Csplit-debuginfo#79570.

I do agree that it's not necessary to extend this logic between two files, so I moved everything into link.rs. Let me know what you think.

ehuss · 2021-04-25T00:51:18Z

That's fine, it was just a thought. The idea would be to handle the case if you are not using ld64 on macos. In this particular case, I don't think it matters too much. If there is a desire to use more ld64-specific flags in the future, it might be worth considering more.

From a cursory glance, this looks good to me. I haven't tested this locally, though. I would still prefer for @pnkfelix or some other compiler team member to review.

Thanks for working on this!

joshtriplett · 2021-06-09T04:24:23Z

@calavera Looking over the codebase a second time, it looks like there are indeed a number of other places making similar assumptions about macOS targets, notably the handling of dsymutil. Given that, while I do think it'd be valuable to switch to a linker flavor, I also don't think this PR needs to do that. Consider the concern withdrawn, please; is_like_osx seems fine for now.

petrochenkov · 2021-06-09T06:07:05Z

r? @petrochenkov
There's nothing wrong with using is_like_osx, and adding a new linker flavor is an orthogonal change (and it's not clear to me whether adding it is worth it).
I'll look at this PR this week.

petrochenkov · 2021-06-09T12:03:13Z

r=me after squashing commits.

As reported in the stabilization issue, MacOS' linker doesn't support the `-s` and `-S` flags to strip symbols anymore. However, the os ships a separated tool to perform these operations. This change allows the compiler to use that tool after a target has been compiled to strip symbols. For rationale, see: rust-lang#72110 (comment) For option selection, see: https://www.unix.com/man-page/osx/1/strip/ Signed-off-by: David Calavera <david.calavera@gmail.com>

calavera · 2021-06-09T16:30:34Z

@petrochenkov I've squashed the commits. GitHub Actions is waiting for a maintainer to approve the workflows before running.

petrochenkov · 2021-06-09T16:31:04Z

@bors r+

petrochenkov · 2021-06-09T19:23:07Z

@bors r+

bors · 2021-06-09T19:23:09Z

📌 Commit df0fc6d has been approved by petrochenkov

Rollup of 7 pull requests Successful merges: - rust-lang#82037 (Make symbols stripping work on MacOS X) - rust-lang#84687 (Multiple improvements to RwLocks) - rust-lang#85997 (rustdoc: Print a warning if the diff when comparing to old nightlies is empty) - rust-lang#86051 (Updated code examples and wording in move keyword documentation ) - rust-lang#86111 (fix off by one in `std::iter::Iterator` documentation) - rust-lang#86113 (build doctests with lld if use-lld = true) - rust-lang#86175 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Enable strip test on macos. This enables the `strip_works` test for macos, which was fixed a while ago in rust-lang/rust#82037.

rust-highfive assigned estebank Feb 12, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2021

eggyal reviewed Mar 2, 2021
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/back/linker.rs Outdated

estebank reviewed Mar 3, 2021
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/back/linker.rs Outdated

ehuss reviewed Mar 8, 2021
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/back/linker.rs Outdated
Comment threadcompiler/rustc_session/src/session.rs Outdated

estebank added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2021

pnkfelix self-assigned this Mar 11, 2021

pnkfelix removed the I-nominated label Mar 11, 2021

joshtriplett mentioned this pull request Mar 12, 2021
Tracking issue for -Z strip=val option #72110
Closed

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2021

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2021

This comment has been minimized.
Sign in to view

calavera requested a review from pnkfelix April 23, 2021 20:00

dbr mentioned this pull request Apr 27, 2021
Strip debug symbols in release GothenburgBitFactory/taskchampion#208
Closed

rust-highfive assigned petrochenkov and unassigned pnkfelix and estebank Jun 9, 2021

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2021

calavera force-pushed the strip_debuginfo_osx branch from 6d9203e to df0fc6dCompare June 9, 2021 16:28

petrochenkov closed this Jun 9, 2021

petrochenkov reopened this Jun 9, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2021

JohnTitor mentioned this pull request Jun 10, 2021
Rollup of 7 pull requests #86186
Merged

bors merged commit 27e84b8 into rust-lang:masterJun 10, 2021

rustbot added this to the 1.54.0 milestone Jun 10, 2021

joshtriplett added relnotes Marks issues that should be documented in the release notes of the next release. and removed relnotes Marks issues that should be documented in the release notes of the next release. labels Jun 10, 2021

calavera deleted the strip_debuginfo_osx branch June 10, 2021 17:31

ehuss mentioned this pull request Sep 9, 2021
Enable strip test on macos. rust-lang/cargo#9889
Merged

bors added a commit to rust-lang/cargo that referenced this pull request Sep 9, 2021
Auto merge of#9889- ehuss:macos-strip, r=alexcrichton
4168727
Enable strip test on macos. This enables the `strip_works` test for macos, which was fixed a while ago in rust-lang/rust#82037.

nagisa mentioned this pull request Sep 28, 2022
The illumos linker does not support --strip-debug #102418
Merged

messense mentioned this pull request Mar 14, 2023
Is it possible to use a custom strip path? rust-cross/cargo-zigbuild#111
Closed

Skgland mentioned this pull request Jul 29, 2024
Fix 32-bit Windows releases so they are the correct architecture GitoxideLabs/gitoxide#1475
Merged

Uh oh!

Uh oh!

Conversation

calavera commented Feb 12, 2021

Uh oh!

rust-highfive commented Feb 12, 2021

Uh oh!

calavera commented Feb 25, 2021

Uh oh!

Uh oh!

eggyal commented Mar 3, 2021

Uh oh!

Uh oh!

estebank commented Mar 3, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ehuss commented Mar 8, 2021

Uh oh!

estebank commented Mar 8, 2021

Uh oh!

pnkfelix commented Mar 11, 2021

Uh oh!

This comment has been minimized.

JohnCSimon commented Apr 18, 2021

Uh oh!

This comment has been minimized.

calavera commented Apr 19, 2021

Uh oh!

This comment has been minimized.

calavera commented Apr 22, 2021

Uh oh!

ehuss commented Apr 25, 2021

Uh oh!

joshtriplett commented Jun 9, 2021

Uh oh!

petrochenkov commented Jun 9, 2021

Uh oh!

petrochenkov commented Jun 9, 2021

Uh oh!

calavera commented Jun 9, 2021

Uh oh!

petrochenkov commented Jun 9, 2021

Uh oh!

petrochenkov commented Jun 9, 2021

Uh oh!

bors commented Jun 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

estebank commented Mar 3, 2021•
edited
Loading