Skip to content

fix off by one in std::iter::Iterator documentation - #86111

Merged
bors merged 2 commits into
rust-lang:masterfrom
spookyvision:master
Jun 10, 2021
Merged

fix off by one in std::iter::Iterator documentation#86111
bors merged 2 commits into
rust-lang:masterfrom
spookyvision:master

Conversation

@spookyvision

@spookyvisionspookyvision commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

the range (0..10) is documented as "The even numbers from zero to ten." - should be ".. to nine".

@rust-highfive

rust-highfive commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2021
@camsteffen

camsteffen commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

Or "to eight"? 🤷

@CDirkx

CDirkx commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

Or "The even numbers less than ten"

JohnTitor
JohnTitor reviewed Jun 9, 2021
View reviewed changes
Comment threadlibrary/core/src/iter/traits/iterator.rs Outdated
@spookyvision@JohnTitor
Update library/core/src/iter/traits/iterator.rs
acc65cc
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor

JohnTitor commented Jun 9, 2021

Copy link
Copy Markdown
Member

Thanks! @bors r+ rollup

@bors

bors commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit acc65cc has been approved by JohnTitor

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2021
@JohnTitorJohnTitor mentioned this pull request Jun 10, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2021
@bors
Auto merge ofrust-lang#86186- JohnTitor:rollup-upaw6wx, r=JohnTitor
c5fbcd3
Rollup of 7 pull requests
Successful merges:
- rust-lang#82037 (Make symbols stripping work on MacOS X)
- rust-lang#84687 (Multiple improvements to RwLocks)
- rust-lang#85997 (rustdoc: Print a warning if the diff when comparing to old nightlies is empty)
- rust-lang#86051 (Updated code examples and wording in move keyword documentation )
- rust-lang#86111 (fix off by one in `std::iter::Iterator` documentation)
- rust-lang#86113 (build doctests with lld if use-lld = true)
- rust-lang#86175 (update Miri)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6a292eb into rust-lang:masterJun 10, 2021
@rustbotrustbot added this to the 1.54.0 milestone Jun 10, 2021
github-actionsBot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
@JohnTitorgitbot
Rollup merge ofrust-lang#86111- spookyvision:master, r=JohnTitor
4ad1d6a
fix off by one in `std::iter::Iterator` documentation
the range `(0..10)` is documented as "The even numbers from zero to ten." - should be ".. to nine".
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor left review comments

Assignees

@dtolnaydtolnay

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

8 participants

@spookyvision@rust-highfive@camsteffen@CDirkx@JohnTitor@bors@dtolnay@rustbot