Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #83067
Merged
Merged
Conversation
Fix ICEs 6792 and 6793 fixesrust-lang#6792, fixesrust-lang#6793. r? `@matthiaskrgr` Fixes the ICEs by replacing `TyCtxt::type_of` with `TypeckResults::expr_ty`. changelog: none
Remove workspace and fix dogfood (again) changelog: none In response to rust-lang/rust-clippy#6733 (comment)
…ith the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test
tests: add test that roughly ensures that our lint messages conform with the diagnostics convention of the rustc dev guide lint message should not start with uppercase letters lint messages should not have punctuation at the end of the last line https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-structure The test reads through all the .stderr files in the testsuit and checks lint messages that start with "help: ", "error: " etc. There is also an exception list for special messages that are deemed acceptable. changelog: make sure lint messages conform with the rustc dev guide and add test
…olds the job limit and paths to the sources and log files
…o the source files of a warning into the lintcheck log This is more convenient when reviewing new lint warnings that popped up in the logs
fix a couple of issues when checking if lintcheck needed rerun after clippy binary changed. I was apparently still comparing the times wrongly, but it should be fixed™ now... I actually looked at the date of the sources.toml and not at the date of the log file! Also fix progress report counter not advancing in squential mode
…ectory from traget/lintcheck/crates to target/lintcheck/sources also update logfile with the dtolnay crates
…p1995 lintcheck, do some refactoring and add more sources refactor: add a Config object don't run in parallel mode by default (it didn't make sense because cargo would lock the shared target dir anyway) show full paths (from repo root) to the source files in clippy warnings so we can just copy the path from the logfile fix more bugs add more crates by dtolnay and embark to the sources toml changelog: lintcheck: refactor some code and add more sources
Ignore UI tests since this change makes rustfmt less friendly with UI test comments.
Rustfmt version "Two" changelog: none This enables some ~bug fixes~ changes from rustfmt. This is more consistent with rustc's config, and should be more forward-compatible. Also, the changes look good IMO. 😃
…earth move lintcheck into its own crate This pr: * moves lintcheck out of `clippy dev` and into its own crate (`lintcheck`) (I should have done this earlier :D) * makes lintcheck terminate if it is not launched from the repo root (to prevent problems with wrong paths when using `cargo run` in the crate root) * fixes json lint messages leaking the runners `$HOME` when a lint messages comes from a proc macro that originates from a crate inside the `$CARGO_CACHE` * adds more documentation to lintchecks `README.md` and mentions lintcheck in `docs/basics.md` changelog: none
Refactor: arrange lints in `methods` module This PR arranges methods lints so that they can be accessed more easily. Basically, I refactored them following the instruction described in rust-lang#6680. changelog: Move lints in methods module into their own modules.
now we can pass this flag since https://reviews.llvm.org/D93002 has been merged.
test: add test case make tidy happy
This will be removed in the next sync, once beta is at 1.52. Until then this hack avoids to put `cfg(bootstrap)` into Clippy.
This way, you can debug rustdoc's JavaScript and CSS file with normal F12 Dev Tools and you'll have useful line numbers to work with.
Simplify ast block lowering
Update Clippy Bi-weekly Clippy sync. r? ``@Manishearth``
Emit the enum range assumption if the range only contains one element closerust-lang#82871
…pass-manager, r=nikic Support merge_functions option in NewPM since LLVM >= 12 now we can pass this flag since https://reviews.llvm.org/D93002 has been merged.
updated vulnerable deps * Updated signal-hook-registry 1.2.1 to 1.2.2, as it drops dependency on vulnerable arc-swap 0.4.7 https://rustsec.org/advisories/RUSTSEC-2020-0091 * Updated generic-array 0.12.3 to 0.12.4, vuln https://rustsec.org/advisories/RUSTSEC-2020-0146 * Updated sized-chunks 0.6.2 to 0.6.4, vuln https://rustsec.org/advisories/RUSTSEC-2020-0041 fixed in 0.6.3, in 0.6.4 fixed some UB https://github.com/bodil/sized-chunks/blob/master/CHANGELOG.md#064---2021-02-17
…ication, r=Mark-Simulacrum Allow configuring `rustdoc --disable-minification` in config.toml This way, you can debug rustdoc's JavaScript and CSS file with normal F12 Dev Tools and you'll have useful line numbers to work with.
JohnTitor
commented
Mar 13, 2021
MemberAuthor
@bors r+ rollup=never p=6 |
bors
commented
Mar 13, 2021
Collaborator
📌 Commit 684fa19 has been approved by |
bors
commented
Mar 13, 2021
Collaborator
bors
commented
Mar 13, 2021
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustdoc --disable-minificationin config.toml #83059 (Allow configuringrustdoc --disable-minificationin config.toml)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup