Suggestion for call on immutable binding of mutable type by estebank · Pull Request #83251 · rust-lang/rust

estebank · 2021-03-18T01:46:22Z

When calling a method requiring a mutable self borrow on an inmutable
to a mutable borrow of the type, suggest making the binding mutable.

Fix#83241.

rust-highfive · 2021-03-18T01:46:25Z

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

estebank · 2021-03-22T19:01:32Z

r? @oli-obk

oli-obk · 2021-03-23T11:13:38Z

All of the changed tests were a case where the previous suggestion was already applicable, and now still is. While the new version fixes the situation, it always does so by introducing another level of indirection that will immediately get autodereffed.

I think this new suggestion should not apply if the expression is a borrow expression. Also we should probably have the test from the issue in the test suite, as it does cover a case that is not covered by any of the changed tests

Dylan-DPC-zz · 2021-04-09T15:19:08Z

@estebank judging by oli's previous comment i'm assuming there are changes expected here

bors · 2021-05-11T10:34:51Z

☔ The latest upstream changes (presumably #85100) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2021-08-09T06:08:34Z

Ping from triage:
@estebank build is broken and there are merge conflicts.

estebank · 2021-08-09T12:00:32Z

Addressed comments, fixed rebase and fixed structured_suggestion (we currently incorrectly suggest removal of code, which is why this PR originally used help instead of suggestion).

oli-obk · 2021-08-09T13:24:22Z

@bors r+ rollup

camelid · 2021-08-29T00:59:13Z

@oli-obk It seems that bors didn't pick up on your approval. Can you try again?

estebank · 2021-08-29T08:28:02Z

@bors r=oli-obk rollup

bors · 2021-08-29T08:28:03Z

📌 Commit b252b38a9f071c5ddaf10fb6f0abe7ccf0c3a7d5 has been approved by oli-obk

estebank · 2021-08-29T08:28:51Z

@bors r-

This has old suggestion format, it'll fail to merge.

When calling a method requiring a mutable self borrow on an inmutable to a mutable borrow of the type, suggest making the binding mutable. Fixrust-lang#83241.

estebank · 2021-08-29T08:49:12Z

@bors r=oli-obk rollup

bors · 2021-08-29T08:49:13Z

📌 Commit 5b6f4b9 has been approved by oli-obk

…laumeGomez Rollup of 13 pull requests Successful merges: - rust-lang#80543 (Notify when an `I-prioritize` issue is closed or reopened) - rust-lang#83251 (Suggestion for call on immutable binding of mutable type) - rust-lang#85534 (add rustc-demangle assertion on mangled symbol) - rust-lang#88173 (Refactor Markdown length-limited summary implementation) - rust-lang#88349 (Add const and static TAIT tests) - rust-lang#88357 (add unsized coercion test) - rust-lang#88381 (Handle stack_t.ss_sp type change for DragonFlyBSD) - rust-lang#88387 (Remove vestigial rustfix tests.) - rust-lang#88396 (Bump vulnerable crates) - rust-lang#88407 (Fix formatting in release notes from 52a9883) - rust-lang#88411 (Remove `Session.if_let_suggestions`) - rust-lang#88417 (RELEASES.md: fix broken link) - rust-lang#88419 (Fix code blocks color in Ayu theme) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned matthewjasper Mar 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2021

rust-highfive assigned oli-obk and unassigned matthewjasper Mar 22, 2021

crlf0710 added A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2021

Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2021

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2021

bstrie added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2021

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2021

JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2021

bstrie added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2021

estebank force-pushed the issue-83241 branch 2 times, most recently from e439111 to faf5dbdCompare August 9, 2021 10:32

This comment has been minimized.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2021

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2021

estebank added 3 commits August 29, 2021 08:34

Suggestion for call on immutable binding of mutable type
e4368de
When calling a method requiring a mutable self borrow on an inmutable to a mutable borrow of the type, suggest making the binding mutable. Fixrust-lang#83241.

Provide structured suggestion for removal of &mut
a6af6d6

rebase: fix test output
5b6f4b9

estebank force-pushed the issue-83241 branch from b252b38 to 5b6f4b9Compare August 29, 2021 08:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2021

GuillaumeGomez mentioned this pull request Aug 29, 2021
Rollup of 13 pull requests #88461
Merged

bors merged commit 22973a8 into rust-lang:masterAug 29, 2021

rustbot added this to the 1.56.0 milestone Aug 29, 2021

Uh oh!

Uh oh!

Conversation

estebank commented Mar 18, 2021

Uh oh!

rust-highfive commented Mar 18, 2021

Uh oh!

estebank commented Mar 22, 2021

Uh oh!

oli-obk commented Mar 23, 2021

Uh oh!

Dylan-DPC-zz commented Apr 9, 2021

Uh oh!

bors commented May 11, 2021

Uh oh!

JohnCSimon commented Aug 9, 2021

Uh oh!

estebank commented Aug 9, 2021

Uh oh!

oli-obk commented Aug 9, 2021

Uh oh!

camelid commented Aug 29, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

estebank commented Aug 29, 2021

Uh oh!

bors commented Aug 29, 2021

Uh oh!

estebank commented Aug 29, 2021

Uh oh!

estebank commented Aug 29, 2021

Uh oh!

bors commented Aug 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants