Fix invalid suggestion of changing impl trait signature

[hkalbasi]

Fix#68049

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[hkalbasi]

Seems @matthewjasper is busy (from github contributions). May I request another reviewer?
r? @Aaron1011

[Aaron1011]

Thank you for your contribution!

There's a large amount of rightward drift in the diff. If it's still there after you switch to tcx.opt_associated_item, could you make a new method for the logic you're adding? That will allow you to return early when a condition doesn't match, which should help keep the rightward drift down.

[hkalbasi]

I moved the logic to a function so right drift is almost solved. I don't think it helps to use tcx.opt_associated_item because I need trait object (td) and my_hir.

@rustbot label -S-waiting-on-author +S-waiting-on-review

[Aaron1011]

I see what you mean about still needing to use the HIR to get the trait method argument span. However, using opt_associated_item should make some of the code preceding that loop much shorter

[hkalbasi]

@Aaron1011 Is it now ok?

[Aaron1011]

@hkalbasi Thanks!

@bors r+

[bors]

📌 Commit 8f5585a has been approved by Aaron1011

[JohnTitor]

Failed in rollup: #85163 (comment)
Note that someone should approve the workflow for first-time contributors.
@bors r-

[hkalbasi]

I thought ./x.py test tidy --bless will fix styling problems automatically.

[hkalbasi]

What is happening here? tidy --bless fix styling but just have problem with trailing whitespaces?

[JohnTitor]

IIRC tidy --bless won't fix all the tidy failures, and I guess that the first failure hides the later ones.

[hkalbasi]

But trailing space is the easiest one I think. Maybe it is a bug?

[JohnTitor]

But trailing space is the easiest one I think. Maybe it is a bug?

Nah, it isn't a bug, --bless means x.py fmt and it won't remove trailing spaces. Just checked on my local and tidy exits with code 1 correctly so I think you missed the failure on your console.

[hkalbasi]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[JohnTitor]

Could you squash extra formatting commits into the existing one to clean up the commit log? Once it's done, I'll back this into the queue.

[hkalbasi]

Done

[JohnTitor]

Thanks! @bors r=Aaron1011

[bors]

📌 Commit 1f20966 has been approved by Aaron1011

[bors]

⌛ Testing commit 1f20966 with merge 382f748...

[bors]

☀️ Test successful - checks-actions
Approved by: Aaron1011
Pushing 382f748 to master...