Skip to content

Stabilize BTree{Map,Set}::retain - #84121

Merged
bors merged 1 commit into
rust-lang:masterfrom
workingjubilee:stabilize-btree-retain
Apr 13, 2021
Merged

Stabilize BTree{Map,Set}::retain#84121
bors merged 1 commit into
rust-lang:masterfrom
workingjubilee:stabilize-btree-retain

Conversation

@workingjubilee

Copy link
Copy Markdown
Member

Closes#79025.
FCP concluded here: #79025 (comment)

This is an approved feature on BTree{Map,Set} to mirror a functionality in Hash{Map,Set}, which has had some adequate testing since its introduction in #79026 and doesn't seem to have caused any problems since.

@workingjubileeworkingjubilee added T-libs-api [DEPRECATED; DO NOT USE] relnotes Marks issues that should be documented in the release notes of the next release. labels Apr 12, 2021
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2021

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 7baeaa9 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2021
Rollup of 6 pull requests
Successful merges:
- rust-lang#83438 (Update RELEASES.md)
- rust-lang#83707 (Remove `T: Debug` bound on UnsafeCell Debug impl)
- rust-lang#84084 (Stabilize duration_zero.)
- rust-lang#84121 (Stabilize BTree{Map,Set}::retain)
- rust-lang#84140 (Don't call bump in check_mistyped_turbofish_with_multiple_type_params)
- rust-lang#84141 (Fix typo in error message)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors

bors commented Apr 13, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7baeaa9 with merge 5258a74...

@bors
bors merged commit cf67c9b into rust-lang:masterApr 13, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 13, 2021
@workingjubilee
workingjubilee deleted the stabilize-btree-retain branch April 23, 2021 19:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for {BTreeMap,BTreeSet}::retain

5 participants

@workingjubilee@rust-highfive@dtolnay@bors@rustbot