Skip to content

Fix typo in error message - #84141

Merged
bors merged 1 commit into
rust-lang:masterfrom
camelid:fix-typo
Apr 13, 2021
Merged

Fix typo in error message#84141
bors merged 1 commit into
rust-lang:masterfrom
camelid:fix-typo

Conversation

@camelid

@camelidcamelid commented Apr 12, 2021

Copy link
Copy Markdown
Member

Also tweaked the message a bit by

  • removing the hyphen, because in my opinion the hyphen makes the
    message a bit harder to read, especially combined with the backticks;
  • adding the word "be", because I think it's a bit clearer that way.

@camelidcamelid added A-const-generics Area: const generics (parameters and arguments) A-diagnostics Area: Messages for errors, warnings, and lints labels Apr 12, 2021
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2021
@Dylan-DPC-zz

Copy link
Copy Markdown

r? @Dylan-DPC

@bors r+ rollup

@bors

bors commented Apr 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 0debe9bb0567ab32076fea819093a25d9aa37bf3 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2021
@rust-log-analyzer

This comment has been minimized.

@Dylan-DPC-zz

Copy link
Copy Markdown

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 12, 2021
Also tweaked the message a bit by
- removing the hyphen, because in my opinion the hyphen makes the
message a bit harder to read, especially combined with the backticks;
- adding the word "be", because I think it's a bit clearer that way.
@camelidcamelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 12, 2021
@Dylan-DPC-zz

Copy link
Copy Markdown

@bors r+

@bors

bors commented Apr 12, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 1e26358 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2021
Rollup of 6 pull requests
Successful merges:
- rust-lang#83438 (Update RELEASES.md)
- rust-lang#83707 (Remove `T: Debug` bound on UnsafeCell Debug impl)
- rust-lang#84084 (Stabilize duration_zero.)
- rust-lang#84121 (Stabilize BTree{Map,Set}::retain)
- rust-lang#84140 (Don't call bump in check_mistyped_turbofish_with_multiple_type_params)
- rust-lang#84141 (Fix typo in error message)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 91c0828 into rust-lang:masterApr 13, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 13, 2021
@camelid
camelid deleted the fix-typo branch April 13, 2021 19:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-const-genericsArea: const generics (parameters and arguments)A-diagnosticsArea: Messages for errors, warnings, and lintsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@camelid@rust-highfive@Dylan-DPC-zz@bors@rust-log-analyzer@petrochenkov@rustbot