Skip to content

Address comments for vecdeque_binary_search #78021 - #84145

Merged
bors merged 3 commits into
rust-lang:masterfrom
vojtechkral:vecdeque-binary-search
Apr 16, 2021
Merged

Address comments for vecdeque_binary_search #78021#84145
bors merged 3 commits into
rust-lang:masterfrom
vojtechkral:vecdeque-binary-search

Conversation

@vojtechkral

@vojtechkralvojtechkral commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Apr 12, 2021

Copy link
Copy Markdown
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2021
@vojtechkralvojtechkral mentioned this pull request Apr 12, 2021
Closed
5 tasks
m-ou-se
m-ou-se reviewed Apr 14, 2021
View reviewed changes

@m-ou-sem-ou-se left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good! Only two comments about the documentation:

Comment threadlibrary/alloc/src/collections/vec_deque/mod.rs Outdated
@m-ou-sem-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api [DEPRECATED; DO NOT USE] and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@vojtechkral
vojtechkralforce-pushed the vecdeque-binary-search branch from efb36c0 to 44be1c2CompareApril 15, 2021 21:24
@vojtechkral

vojtechkral commented Apr 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@m-ou-se updated, fixed the doc comments hopefully...

@m-ou-se

m-ou-se commented Apr 16, 2021

Copy link
Copy Markdown
Member

Thanks for working on this!

@bors r+

@bors

bors commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 44be1c2 has been approved by m-ou-se

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2021
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2021
@bors
Auto merge ofrust-lang#84241- Dylan-DPC:rollup-jk9nt6k, r=Dylan-DPC
2faef12
Rollup of 4 pull requests
Successful merges:
- rust-lang#83337 (rustdoc: Hide item contents, not items)
- rust-lang#83944 (Fix a couple resolve bugs from binder refactor)
- rust-lang#84145 (Address comments for vecdeque_binary_search rust-lang#78021)
- rust-lang#84172 (Compiler error messages: reduce assertiveness of message E0384)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a5ec5cf into rust-lang:masterApr 16, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-ou-sem-ou-sem-ou-se left review comments

Assignees

@m-ou-sem-ou-se

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

5 participants

@vojtechkral@rust-highfive@m-ou-se@bors@rustbot