Skip to content

Compiler error messages: reduce assertiveness of message E0384 - #84172

Merged
bors merged 2 commits into
rust-lang:masterfrom
jayaddison:compiler/E0384-reduce-assertiveness
Apr 16, 2021
Merged

Compiler error messages: reduce assertiveness of message E0384#84172
bors merged 2 commits into
rust-lang:masterfrom
jayaddison:compiler/E0384-reduce-assertiveness

Conversation

@jayaddison

@jayaddisonjayaddison commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

This message is emitted as guidance by the compiler when a developer attempts to reassign a value to an immutable variable. Following the message will always currently work, but it may not always be the best course of action; following the 'consider ...' messaging pattern provides a hint to the developer that it could be wise to explore other alternatives.

Resolves#84144

@jayaddison
Compiler error messages: reduce assertiveness of message E0384
0174dd6
This message is emitted as guidance by the compiler when a developer attempts to reassign a value to an immutable variable. Following the message will always currently work, but it may not always be the best course of action; following the 'consider ...' messaging pattern provides a hint to the developer that it could be wise to explore other alternatives.
@rust-highfive

rust-highfive commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2021
@petrochenkov

petrochenkov commented Apr 13, 2021

Copy link
Copy Markdown
Contributor

Thanks!
@bors r+

@bors

bors commented Apr 13, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 0174dd6 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2021
@bors

bors commented Apr 13, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0174dd6 with merge c091589eabb1cd80ff2666d7441dbd88740daf3c...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Apr 13, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2021
@petrochenkov

petrochenkov commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

The failure looks spurious and unrelated, @bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@bors

bors commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0174dd6 with merge 046bb46807fe7180d118c1513ddc27c330951006...

@bors

bors commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 14, 2021
@jayaddison

jayaddison commented Apr 14, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks @petrochenkov; I did notice that a very similar error to #84172 (comment) was also reported at #83610 (comment) (cc @bjorn3) - perhaps there's a bug to find in the build process somewhere?

@petrochenkov

petrochenkov commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@petrochenkov

petrochenkov commented Apr 16, 2021

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 16, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit ff47e97 has been approved by petrochenkov

@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2021
@bors
Auto merge ofrust-lang#84241- Dylan-DPC:rollup-jk9nt6k, r=Dylan-DPC
2faef12
Rollup of 4 pull requests
Successful merges:
- rust-lang#83337 (rustdoc: Hide item contents, not items)
- rust-lang#83944 (Fix a couple resolve bugs from binder refactor)
- rust-lang#84145 (Address comments for vecdeque_binary_search rust-lang#78021)
- rust-lang#84172 (Compiler error messages: reduce assertiveness of message E0384)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c7c59d7 into rust-lang:masterApr 16, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 16, 2021
@jayaddison
jayaddison deleted the compiler/E0384-reduce-assertiveness branch April 16, 2021 17:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

Immutable variable reassignment help message

6 participants

@jayaddison@rust-highfive@petrochenkov@bors@rust-log-analyzer@rustbot