Skip to content

rustdoc: Give a more accurate span for anchor failures - #84203

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:anchor-span
Apr 17, 2021
Merged

rustdoc: Give a more accurate span for anchor failures#84203
bors merged 1 commit into
rust-lang:masterfrom
jyn514:anchor-span

Conversation

@jyn514

@jyn514jyn514 commented Apr 14, 2021

Copy link
Copy Markdown
Member

@jyn514jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@bors

This comment has been minimized.

Sign in to view
euclio
euclio reviewed Apr 17, 2021
View reviewed changes
Comment threadsrc/librustdoc/passes/collect_intra_doc_links.rs Outdated
@euclio

euclio commented Apr 17, 2021

Copy link
Copy Markdown
Contributor

I don't have bors privileges, but LGTM.

@jyn514

jyn514 commented Apr 17, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks for the review!

@bors r=euclio

@bors

bors commented Apr 17, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 59546ef has been approved by euclio

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 17, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2021
@bors
Auto merge ofrust-lang#84279- Dylan-DPC:rollup-k7otd7e, r=Dylan-DPC
392ba2b
Rollup of 4 pull requests
Successful merges:
- rust-lang#83237 (rustdoc: use more precise relative URLs)
- rust-lang#84150 (rustdoc: move some search code into search.js)
- rust-lang#84203 (rustdoc: Give a more accurate span for anchor failures)
- rust-lang#84257 (Add documentation to help people find `Ipv4Addr::UNSPECIFIED`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d919a5a into rust-lang:masterApr 17, 2021
@rustbotrustbot added this to the 1.53.0 milestone Apr 17, 2021
@jyn514
jyn514 deleted the anchor-span branch April 18, 2021 04:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@euclioeuclioeuclio left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-diagnosticsArea: Messages for errors, warnings, and lintsA-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.53.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jyn514@bors@euclio@rustbot