Uh oh!
There was an error while loading. Please reload this page.
Add documentation to help people find Ipv4Addr::UNSPECIFIED - #84257
Merged
Conversation
rust-highfive
commented
Apr 16, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
joshtriplett
commented
Apr 16, 2021
MemberAuthor
r? @m-ou-se |
IpAddr::UNSPECIFIEDIpv4Addr::UNSPECIFIEDm-ou-se
commented
Apr 16, 2021
Member
Looks like a good use case for |
joshtriplett
commented
Apr 16, 2021
MemberAuthor
@m-ou-se I'd be happy to add that as well, I just knew we were still discussing when that was appropriate to use. If you think it's fine in this case, I'll add it. |
People looking for `INADDR_ANY` don't always find `Ipv4Addr::UNSPECIFIED`; add some documentation and an alias to help.
m-ou-se
commented
Apr 16, 2021
Member
@bors r+ rollup |
bors
commented
Apr 16, 2021
Collaborator
📌 Commit 9aa4d06 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 17, 2021
Add documentation to help people find `Ipv4Addr::UNSPECIFIED` People looking for `INADDR_ANY` don't always find `Ipv4Addr::UNSPECIFIED`; add some documentation to help.
This was referenced Apr 17, 2021
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2021
Rollup of 4 pull requests Successful merges: - rust-lang#83237 (rustdoc: use more precise relative URLs) - rust-lang#84150 (rustdoc: move some search code into search.js) - rust-lang#84203 (rustdoc: Give a more accurate span for anchor failures) - rust-lang#84257 (Add documentation to help people find `Ipv4Addr::UNSPECIFIED`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People looking for
INADDR_ANYdon't always findIpv4Addr::UNSPECIFIED;add some documentation to help.