Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #85014
Merged
Merged
Conversation
std::sync::mpsc uses thread locals and depending on the order TLS dtors are run `rx.recv()` can panic when used in a TLS dtor.
This controls whether run-* tests actually get run.
I was wary of doing any automatic disabling here, since should-fail is how we test compiletest itself.
I came up with this idea ages ago, but rustdoc used to ICE on it. Now it doesn't.
The comment says that build dependencies shouldn't matter unless they do some kind of codegen. It is safer to always check it though.
using allow_internal_unstable (as recommended) Fixes: rust-lang#84836 ```shell $ ./build/x86_64-unknown-linux-gnu/stage1/bin/rustc src/test/run-make-fulldeps/coverage/no_cov_crate.rs error[E0554]: `#![feature]` may not be used on the dev release channel --> src/test/run-make-fulldeps/coverage/no_cov_crate.rs:2:1 | 2 | #![feature(no_coverage)] | ^^^^^^^^^^^^^^^^^^^^^^^^ error: aborting due to previous error For more information about this error, try `rustc --explain E0554`. ```
I just need this until rustbuild supports -Cpanic=abort std directly.
… thread 1 enters TLS destructors
This is a regression test for rust-lang#82820. This test case is included in more general tests, but I think the error regressed because there were a bunch of other diagnostic changes in the test that obscured this regression. Hopefully, having a test specific to the suggestion, and running rustfix for the test, will prevent this error from regressing in the future.
…r=jethrogb Ensure TLS destructors run before thread joins in SGX The excellent test is from ```@jethrogb``` For context see: rust-lang#83416 (comment)
…k-Simulacrum Add --run flag to compiletest This controls whether run-* tests actually get run. r? ```@Mark-Simulacrum```
…rk-Simulacrum Add test for suggestion to borrow unsized function parameters Closesrust-lang#82820. This is a regression test for rust-lang#82820. This test case is included in more general tests, but I think the error regressed because there were a bunch of other diagnostic changes in the test that obscured this regression. Hopefully, having a test specific to the suggestion, and running rustfix for the test, will prevent this error from regressing in the future.
…=Mark-Simulacrum Add `needs-unwind` and beginning of support for testing `panic=abort` std to compiletest For the Fuchsia platform we build libstd with `panic=abort` and would like a way to run tests with that enabled. This adds low-level support for this directly to compiletest. In the future I'd like to add high-level support in rustbuild, e.g. having target-specific flags that allow configuring a panic strategy. (Side note: It would be nice if we could also build multiple configurations for the same target, but I'm getting ahead of myself.) This plus rust-lang#84500 have everything that's needed to get ui tests passing on fuchsia targets. Part of rust-lang#84766. Note that this change only includes the header on tests which need an unwinder to _build_, not those which need it to _run_. r? ````@Mark-Simulacrum````
Allow using `core::` in intra-doc links within core itself I came up with this idea ages ago, but rustdoc used to ICE on it. Now it doesn't. Helps with rust-lang#73445. Doesn't fix it completely since `extern crate self as std;` in std still gives strange errors.
…, r=nagisa Disallows `#![feature(no_coverage)]` on stable and beta (using standard crate-level gating) Fixes: rust-lang#84836 Removes the function-level feature gating solution originally implemented, and solves the same problem using `allow_internal_unstable`, so normal crate-level feature gating mechanism can still be used (which disallows the feature on stable and beta). I tested this, building the compiler with and without `CFG_DISABLE_UNSTABLE_FEATURES=1` With unstable features disabled, I get the expected result as shown here: ```shell $ ./build/x86_64-unknown-linux-gnu/stage1/bin/rustc src/test/run-make-fulldeps/coverage/no_cov_crate.rs error[E0554]: `#![feature]` may not be used on the dev release channel --> src/test/run-make-fulldeps/coverage/no_cov_crate.rs:2:1 | 2 | #![feature(no_coverage)] | ^^^^^^^^^^^^^^^^^^^^^^^^ error: aborting due to previous error For more information about this error, try `rustc --explain E0554`. ``` r? ````@Mark-Simulacrum```` cc: ````@tmandry```` ````@wesleywiser````
Wire up tidy dependency checks for cg_clif Also contains a fix and improvement to tidy. Required for rust-lang#81746.
Handle incorrect placement of parentheses in trait bounds more gracefully Fixrust-lang#84772. CC ``````@jonhoo``````
CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs The `copy` name is confusing for this function because we also have `copy_op` which is pretty different. I hope `copy_intrinsic` is clearer. Also `step.rs` should really just contain the main loop and opcode dispatch, so move this helper function to a more appropriate place. r? ``````@oli-obk``````
…_default_session_globals, r=jyn514 Remove unneeded call to with_default_session_globals in rustdoc highlight This was the origin of the `Span` bug in rust-lang#84176. cc `````@Aaron1011````` r? `````@jyn514`````
Dylan-DPC-zz
commented
May 6, 2021
Author
@bors r+ rollup=never p=5 |
bors
commented
May 6, 2021
Collaborator
📌 Commit 01e9d09 has been approved by |
bors
commented
May 7, 2021
Collaborator
bors
commented
May 7, 2021
Collaborator
☀️ Test successful - checks-actions |
This was referenced May 7, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
needs-unwindand beginning of support for testingpanic=abortstd to compiletest #84734 (Addneeds-unwindand beginning of support for testingpanic=abortstd to compiletest)core::in intra-doc links within core itself #84755 (Allow usingcore::in intra-doc links within core itself)#![feature(no_coverage)]on stable and beta (using standard crate-level gating) #84871 (Disallows#![feature(no_coverage)]on stable and beta (using standard crate-level gating))Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup