Uh oh!
There was an error while loading. Please reload this page.
Move std::memchr to sys_common - #85275
Merged
Merged
Conversation
rust-highfive
commented
May 14, 2021
Contributor
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
m-ou-se
commented
May 19, 2021
Member
Thanks! @bors r+ |
bors
commented
May 19, 2021
Collaborator
📌 Commit 5353c5c has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 19, 2021
Move `std::memchr` to `sys_common` `std::memchr` is a thin abstraction over the different `memchr` implementations in `sys`, along with documentation and tests. The module is only used internally by `std`, nothing is exported externally. Code like this is exactly what the `sys_common` module is for, so this PR moves it there.
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 19, 2021
Move `std::memchr` to `sys_common` `std::memchr` is a thin abstraction over the different `memchr` implementations in `sys`, along with documentation and tests. The module is only used internally by `std`, nothing is exported externally. Code like this is exactly what the `sys_common` module is for, so this PR moves it there.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#85275 (Move `std::memchr` to `sys_common`) - rust-lang#85326 (bootstrap: ensure host std when cross-compiling tools, fixesrust-lang#85320) - rust-lang#85375 (Fix missing lifetimes diagnostics after rust-lang#83759) - rust-lang#85507 (Extend escape key check) - rust-lang#85509 (Prevent tab title to "null" if the URL is a search one) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::memchris a thin abstraction over the differentmemchrimplementations insys, along with documentation and tests. The module is only used internally bystd, nothing is exported externally. Code like this is exactly what thesys_commonmodule is for, so this PR moves it there.