Uh oh!
There was an error while loading. Please reload this page.
Rollup of 13 pull requests - #85483
Closed
Dylan-DPC-zz wants to merge 39 commits into
Closed
Conversation
These features were recently added to std_detect. Features not supported by LLVM 9, the current minimum version for Rust, are commented.
In https://reviews.llvm.org/D102093 lots of things stopped taking the DebugLogging boolean parameter. Mercifully we appear to always set DebugPassManager to false, so I don't think we're losing anything by not passing this parameter.
The makes the code for handling "auto-hide" settings more consistent.
…forms can specialize it
…nieu Update list of allowed aarch64 features I recently added these features to std_detect for aarch64 linux, pending [review](rust-lang/stdarch#1146). I have commented any features not supported by LLVM 9, the current minimum version for Rust. Some (PAuth at least) were renamed between 9 & 12 and I've left them disabled. TME, however, is not in LLVM 9 but I've left it enabled. See rust-lang/stdarch#993
Introduce `sys_common::rt::rtprintpanic!` to replace `sys_common::util` functionality This PR introduces a new macro `rtprintpanic!`, similar to `sys_common::util::dumb_print` and uses that macro to replace all `sys_common::util` functionality.
impl FromStr for proc_macro::Literal
Note that unlike `impl FromStr for proc_macro::TokenStream`, this impl does not permit whitespace or comments. The input string must consist of nothing but your literal.
- `"1".parse::<Literal>()` ⟶ ok
- `"1.0".parse::<Literal>()` ⟶ ok
- `"'a'".parse::<Literal>()` ⟶ ok
- `"\"\n\"".parse::<Literal>()` ⟶ ok
- `"0 1".parse::<Literal>()` ⟶ LexError
- `" 0".parse::<Literal>()` ⟶ LexError
- `"0 ".parse::<Literal>()` ⟶ LexError
- `"/* comment */0".parse::<Literal>()` ⟶ LexError
- `"0/* comment */".parse::<Literal>()` ⟶ LexError
- `"0// comment".parse::<Literal>()` ⟶ LexError
---
## Use case
```rust
let hex_int: Literal = format!("0x{:x}", int).parse().unwrap();
```
The only way this is expressible in the current API is significantly worse.
```rust
let hex_int = match format!("0x{:x}", int)
.parse::<TokenStream>()
.unwrap()
.into_iter()
.next()
.unwrap()
{
TokenTree::Literal(literal) => literal,
_ => unreachable!(),
};
```Windows implementation of feature `path_try_exists` Draft of a Windows implementation of `try_exists` (rust-lang#83186). The first commit reorganizes the code so I would be interested to get some feedback on if this is a good idea or not. It moves the `Path::try_exists` function to `fs::exists`. leaving the former as a wrapper for the latter. This makes it easier to provide platform specific implementations and matches the `fs::metadata` function. The other commit implements a Windows specific variant of `exists`. I'm still figuring out my approach so this is very much a first draft. Eventually this will need some more eyes from knowledgable Windows people.
Add method-toggle to <details> for methods The makes the code for handling "auto-hide" settings more consistent. Demo at https://hoffman-andrews.com/rust/hoist-classes/std/string/struct.String.htmlFixesrust-lang#84829
Move `std::memchr` to `sys_common` `std::memchr` is a thin abstraction over the different `memchr` implementations in `sys`, along with documentation and tests. The module is only used internally by `std`, nothing is exported externally. Code like this is exactly what the `sys_common` module is for, so this PR moves it there.
…ou-se Expose `Concurrent` (private type in public i'face) rust-lang#53410 introduced experimental support for custom test frameworks. Such frameworks may wish to build upon `library/test` by calling into its publicly exposed API (which I entirely understand is wholly unstable). However, any that wish to call `test::run_test` cannot currently do so because `test::options::Concurrent` (the type of its `concurrent` parameter) is not publicly exposed.
…=jonas-schievink ⬆️ rust-analyzer
…gisa PassWrapper: update for LLVM change D102093 In https://reviews.llvm.org/D102093 lots of things stopped taking the DebugLogging boolean parameter. Mercifully we appear to always set DebugPassManager to false, so I don't think we're losing anything by not passing this parameter.
…_type, r=davidtwco Add diagnostic item to `CStr` Required for clippy issue: rust-lang/rust-clippy#7145
…=dtolnay Fix UB in documented example for `ptr::swap` Compare [this (short) discussion on zulip](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Pointers.20to.20overlapping.20arrays) (or [in the archive](https://zulip-archive.rust-lang.org/122651general/92017Pointerstooverlappingarrays.html), if you don’t have an account). `@rustbot` label T-doc T-libs
Fix invalid CSS rules for a:hover When hovering some links:   It is a side-effect from rust-lang#84462. r? ``@jsha``
CTFE Machine: do not expose Allocation `Memory` is careful now to not expose direct access to `Allocation`, but this one slipped through. r? `@oli-obk`
Dylan-DPC-zz
commented
May 19, 2021
Author
@bors r+ rollup=never p=5 |
bors
commented
May 19, 2021
Collaborator
📌 Commit 21007ee has been approved by |
bors
commented
May 19, 2021
Collaborator
⌛ Testing commit 21007ee with merge 543b8da4a8df7d15dab6b40480aba346333f9f4f... |
rust-log-analyzer
commented
May 19, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
May 19, 2021
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
sys_common::rt::rtprintpanic!to replacesys_common::utilfunctionality #84697 (Introducesys_common::rt::rtprintpanic!to replacesys_common::utilfunctionality)path_try_exists#85060 (Windows implementation of featurepath_try_exists)Details
for methods)std::memchrtosys_common#85275 (Movestd::memchrtosys_common)Concurrent(private type in public i'face) #85287 (ExposeConcurrent(private type in public i'face))CStr#85439 (Add diagnostic item toCStr)ptr::swap#85464 (Fix UB in documented example forptr::swap)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup