Skip to content

Fix rustdoc stabilized versions layout - #86370

Merged
bors merged 1 commit into
rust-lang:masterfrom
matteo-briani:fix-rustdoc-stabilized-versions-layout
Jun 19, 2021
Merged

Fix rustdoc stabilized versions layout#86370
bors merged 1 commit into
rust-lang:masterfrom
matteo-briani:fix-rustdoc-stabilized-versions-layout

Conversation

@matteo-briani

@matteo-brianimatteo-briani commented Jun 16, 2021

Copy link
Copy Markdown

@rust-highfive

rust-highfive commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2021
GuillaumeGomez
GuillaumeGomez reviewed Jun 16, 2021
View reviewed changes
Comment threadsrc/librustdoc/html/static/rustdoc.css Outdated

@GuillaumeGomezGuillaumeGomezJun 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing this, please add position: relative; to .small-section-header {.

@matteo-brianimatteo-brianiJun 17, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for the hint

@matteo-brianimatteo-brianiJun 17, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly force-pushed, it should have been an extra commit as I read from @rust-highfive ...my bad!

@GuillaumeGomezGuillaumeGomezJun 17, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue. :)

@matteo-briani
matteo-brianiforce-pushed the fix-rustdoc-stabilized-versions-layout branch from b500a59 to 68f9172CompareJune 17, 2021 08:24
@GuillaumeGomez

GuillaumeGomez commented Jun 17, 2021

Copy link
Copy Markdown
Member

Waiting for CI to pass then approving it.

@GuillaumeGomez

GuillaumeGomez commented Jun 18, 2021

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jun 18, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 68f9172 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2021
@JohnTitorJohnTitor mentioned this pull request Jun 19, 2021
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 19, 2021
@Dylan-DPC
Rollup merge ofrust-lang#86370- matteo-briani:fix-rustdoc-stabilize…
6b7ea65
…d-versions-layout, r=GuillaumeGomez
Fix rustdoc stabilized versions layout
Fixesrust-lang#86342
r? ``@GuillaumeGomez``
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Jun 19, 2021
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2021
@bors
Auto merge ofrust-lang#86456- JohnTitor:rollup-jjzupny, r=JohnTitor
9839f9c
Rollup of 9 pull requests
Successful merges:
- rust-lang#86136 (Stabilize span_open() and span_close().)
- rust-lang#86359 (Use as_secs_f64 in JunitFormatter)
- rust-lang#86370 (Fix rustdoc stabilized versions layout)
- rust-lang#86397 (Alter std::cell::Cell::get_mut documentation)
- rust-lang#86407 (Use `map_or` instead of open-coding it)
- rust-lang#86425 (Update rustversion to 1.0.5)
- rust-lang#86440 (Update library tracking issue for libs-api rename.)
- rust-lang#86444 (Fix ICE with `#[repr(simd)]` on enum)
- rust-lang#86453 (stdlib: Fix typo in internal RefCell docs )
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 41bf471 into rust-lang:masterJun 19, 2021
@rustbotrustbot added this to the 1.55.0 milestone Jun 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

rustdoc: stabilized (added) versions of enum variants are hard to read

5 participants

@matteo-briani@rust-highfive@GuillaumeGomez@bors@rustbot