Uh oh!
There was an error while loading. Please reload this page.
Fix ICE with #[repr(simd)] on enum - #86444
Merged
Merged
Conversation
rust-highfive
commented
Jun 18, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
LeSeulArtichaut
approved these changes
Jun 18, 2021
LeSeulArtichaut
left a comment
Contributor
There was a problem hiding this comment.
One less ICE in the compiler!
LeSeulArtichaut
commented
Jun 18, 2021
Contributor
@bors r+ |
bors
commented
Jun 18, 2021
Collaborator
📌 Commit e7a1186 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 19, 2021
…tichaut Fix ICE with `#[repr(simd)]` on enum This pull request fixesrust-lang#83505. `#[repr(simd)]` may only be applied to structs, which correctly causes `E0517` for the example given in rust-lang#83505, but the compiler attempts to recover from this error, which leads to an ICE later, when `.non_enum_variant()` is called on the `AdtDef`. I have added a check that prevents this from happening.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#86136 (Stabilize span_open() and span_close().) - rust-lang#86359 (Use as_secs_f64 in JunitFormatter) - rust-lang#86370 (Fix rustdoc stabilized versions layout) - rust-lang#86397 (Alter std::cell::Cell::get_mut documentation) - rust-lang#86407 (Use `map_or` instead of open-coding it) - rust-lang#86425 (Update rustversion to 1.0.5) - rust-lang#86440 (Update library tracking issue for libs-api rename.) - rust-lang#86444 (Fix ICE with `#[repr(simd)]` on enum) - rust-lang#86453 (stdlib: Fix typo in internal RefCell docs ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes#83505.
#[repr(simd)]may only be applied to structs, which correctly causesE0517for the example given in #83505, but the compiler attempts to recover from this error, which leads to an ICE later, when.non_enum_variant()is called on theAdtDef. I have added a check that prevents this from happening.