Uh oh!
There was an error while loading. Please reload this page.
Fix autoborrowing when coercing to a mutable raw pointer - #86647
Fix autoborrowing when coercing to a mutable raw pointer#86647FabianWolff wants to merge 1 commit into
Conversation
rust-highfive
commented
Jun 26, 2021
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
jackh726
commented
Jun 30, 2021
Not too familiar with this code. And seems pretty important in terms of soundness. So I don't feel comfortable reviewing this myself. Trying to pick someone randomly, but avoiding people that aren't around atm; let's r? @Aaron1011 |
Aaron1011
commented
Jun 30, 2021
This seems to make sense, but I wonder if there's some language design reason why this wasn't previously allowed. cc @rust-lang/lang |
nikomatsakis
commented
Jul 6, 2021
Discussed in the @rust-lang/lang team meeting today. We weren't really sure what is being proposed here! @scottmcm is going to follow up and try to figure out how to describe the effects of this proposed PR on the language itself. |
Dylan-DPC
commented
Feb 19, 2022
@scottmcm any updates on the follow up? |
bors
commented
Sep 27, 2022
☔ The latest upstream changes (presumably #102306) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
commented
Nov 27, 2022
@FabianWolff @rustbot label: +S-inactive |
This PR fixes#86262. Essentially, the problem is that
apply_adjustments()inFnCtxtcurrently only takes mutability of references into account for automatic borrows, while it should also consider mutable raw pointers. I have fixed this, so that the example in #86262 compiles with my changes.