Skip to content

Implement concat_bytes! - #87599

Merged
bors merged 1 commit into
rust-lang:masterfrom
syvb:concat_bytes
Dec 9, 2021
Merged

Implement concat_bytes!#87599
bors merged 1 commit into
rust-lang:masterfrom
syvb:concat_bytes

Conversation

@syvb

@syvbsyvb commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

This implements the unstable concat_bytes! macro, which has tracking issue #87555. It can be used like:

#![feature(concat_bytes)]fnmain(){assert_eq!(concat_bytes!(),&[]);assert_eq!(concat_bytes!(b'A',b"BC",[68,b'E',70]),b"ABCDEF");}

If strings or characters are used where byte strings or byte characters are required, it suggests adding a b prefix. If a number is used outside of an array it suggests arrayifying it. If a boolean is used it suggests replacing it with the numeric value of that number. Doubly nested arrays of bytes are disallowed.

@rust-highfive

rust-highfive commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2021
@syvbsyvb mentioned this pull request Jul 29, 2021
Open
4 tasks
@Fishrock123

Fishrock123 commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

Just pointing out that the RFC contains a bit of a contradiction and this PR's tests don't appear to test that case: rust-lang/rfcs#2509 (comment)

@syvb

syvb commented Jul 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@Fishrock123 That appears to have been an oversight when updating the RFC. I've added a test for it.

@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
@inquisitivecrystalinquisitivecrystal added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api [DEPRECATED; DO NOT USE] labels Aug 24, 2021
@JohnCSimonJohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2021
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2021
@jplattejplatte mentioned this pull request Oct 6, 2021
Closed
@JohnCSimonJohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2021
@jackh726

jackh726 commented Oct 21, 2021

Copy link
Copy Markdown
Member

Rerolling

r? rust-lang/compiler

Mark-Simulacrum
Mark-Simulacrum reviewed Oct 31, 2021
View reviewed changes
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/concat_bytes.rs Outdated
Comment threadlibrary/core/src/macros/mod.rs Outdated
@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2021
@JohnCSimon

JohnCSimon commented Dec 5, 2021

Copy link
Copy Markdown

Looks like this is ready for review
@rustbot label: -S-waiting-on-author +S-waiting-on-review

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 5, 2021
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 5, 2021
@syvb@Mark-Simulacrum
Implement concat_bytes!
eb56693
The tracking issue for this is rust-lang#87555.
@Mark-Simulacrum

Mark-Simulacrum commented Dec 7, 2021

Copy link
Copy Markdown
Member

Squashed commits, looks good to me, thanks!

@bors r+

@bors

bors commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit eb56693 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2021
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 9, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2021
@bors
Auto merge ofrust-lang#91692- matthiaskrgr:rollup-u7dvh0n, r=matthi…
600820d
…askrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#87599 (Implement concat_bytes!)
- rust-lang#89999 (Update std::env::temp_dir to use GetTempPath2 on Windows when available.)
- rust-lang#90796 (Remove the reg_thumb register class for asm! on ARM)
- rust-lang#91042 (Use Vec extend instead of repeated pushes on several places)
- rust-lang#91634 (Do not attempt to suggest help for overly malformed struct/function call)
- rust-lang#91685 (Install llvm tools to sysroot when assembling local toolchain)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3fc5bd7 into rust-lang:masterDec 9, 2021
@rustbotrustbot added this to the 1.59.0 milestone Dec 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

11 participants

@syvb@rust-highfive@Fishrock123@jackh726@JohnCSimon@Mark-Simulacrum@bors@oli-obk@matthewjasper@inquisitivecrystal@rustbot