Use Vec extend instead of repeated pushes on several places by Kobzol · Pull Request #91042 · rust-lang/rust

Kobzol · 2021-11-19T15:30:08Z

Inspired by #90813, I tried to use a simple regex (for .*in.*\{\n.*push\(.*\);\n\s+}) to search for more places that would use Vec::push in a loop and replace them with Vec::extend.

These probably won't have as much perf. impact as the original PR (if any), but it would probably be better to do a perf run to see if there are not any regressions.

rust-highfive · 2021-11-19T15:30:11Z

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

jyn514 · 2021-11-19T15:57:36Z

@bors try @rust-timer queue

rust-timer · 2021-11-19T15:57:38Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-11-19T15:57:45Z

⌛ Trying commit ad94a04fa16f53a0ac69983b8e7d6bf9640453a1 with merge 76d592791c8d5353c733921c2564ffb0b6b2ed3b...

nagisa · 2021-11-19T23:25:02Z

@bors try @rust-timer queue

rust-timer · 2021-11-19T23:25:03Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-11-19T23:25:10Z

⌛ Trying commit 3e9d1b944e9b6d599415446bf0ffc3dfe1e32718 with merge 826bfd4f40a8dcd4947f74103178fb991029a322...

bors · 2021-11-20T01:02:11Z

☀️ Try build successful - checks-actions
Build commit: 826bfd4f40a8dcd4947f74103178fb991029a322 (826bfd4f40a8dcd4947f74103178fb991029a322)

rust-timer · 2021-11-20T01:02:13Z

Queued 826bfd4f40a8dcd4947f74103178fb991029a322 with parent a77da2d, future comparison URL.

rust-timer · 2021-11-20T02:33:06Z

Finished benchmarking commit (826bfd4f40a8dcd4947f74103178fb991029a322): comparison url.

Summary: This change led to very large relevant regressions 😿 in compiler performance.

Very large regression in instruction counts (up to 5.3% on incr-unchanged builds of inflate)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Kobzol · 2021-11-20T14:10:43Z

Hmm, I could investigate the regression, but since it seems that there are no big improvements either, I wonder if it's worth it to do these changes at all?

jyn514 · 2021-11-20T14:15:50Z

@Kobzol FYI perf has been very unreliable lately, so this doesn't necessarily mean your change is slower. There's a Zulip thread about it somewhere.

nagisa · 2021-12-08T21:07:58Z

r=me once the conflicts are resolved.

Kobzol · 2021-12-08T21:59:00Z

@nagisa I kept only the less controversial changes and rebased. (I don't have permissions to r=you though I suppose)

nagisa · 2021-12-08T22:37:55Z

@bors r+ rollup

Thanks!

bors · 2021-12-08T22:37:57Z

📌 Commit 883d0a7 has been approved by nagisa

…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91042 (Use Vec extend instead of repeated pushes on several places) - rust-lang#91476 (Improve 'cannot contain emoji' error.) - rust-lang#91568 (Pretty print break and continue without redundant space) - rust-lang#91645 (Implement `core::future::join!`) - rust-lang#91666 (update Miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Use Vec extend instead of repeated pushes on several places Inspired by rust-lang#90813, I tried to use a simple regex (`for .*in.*\{\n.*push\(.*\);\n\s+}`) to search for more places that would use `Vec::push` in a loop and replace them with `Vec::extend`. These probably won't have as much perf. impact as the original PR (if any), but it would probably be better to do a perf run to see if there are not any regressions.

…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#87599 (Implement concat_bytes!) - rust-lang#89999 (Update std::env::temp_dir to use GetTempPath2 on Windows when available.) - rust-lang#90796 (Remove the reg_thumb register class for asm! on ARM) - rust-lang#91042 (Use Vec extend instead of repeated pushes on several places) - rust-lang#91634 (Do not attempt to suggest help for overly malformed struct/function call) - rust-lang#91685 (Install llvm tools to sysroot when assembling local toolchain) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned nagisa Nov 19, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 19, 2021

jyn514 added I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 19, 2021

the8472 reviewed Nov 19, 2021
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/format.rs Outdated
Comment threadcompiler/rustc_builtin_macros/src/format.rs Outdated

Kobzol force-pushed the vec-extend-cleanup branch from ad94a04 to 295efccCompare November 19, 2021 17:22

This comment has been minimized.
Sign in to view

Kobzol force-pushed the vec-extend-cleanup branch from 295efcc to 3e9d1b9Compare November 19, 2021 17:34

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 19, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 20, 2021

nagisa reviewed Dec 8, 2021
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/format.rs Outdated

nagisa removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2021

nagisa added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 8, 2021

Use Vec extend instead of repeated pushes in several places
883d0a7

Kobzol force-pushed the vec-extend-cleanup branch from 3e9d1b9 to 883d0a7Compare December 8, 2021 21:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 8, 2021

matthiaskrgr mentioned this pull request Dec 9, 2021
Rollup of 5 pull requests #91691
Merged

matthiaskrgr mentioned this pull request Dec 9, 2021
Rollup of 6 pull requests #91692
Merged

bors merged commit 793648a into rust-lang:masterDec 9, 2021

rustbot added this to the 1.59.0 milestone Dec 9, 2021

Kobzol deleted the vec-extend-cleanup branch December 9, 2021 07:10

Uh oh!

Uh oh!

Conversation

Kobzol commented Nov 19, 2021

Uh oh!

rust-highfive commented Nov 19, 2021

Uh oh!

jyn514 commented Nov 19, 2021

Uh oh!

rust-timer commented Nov 19, 2021

Uh oh!

bors commented Nov 19, 2021

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

nagisa commented Nov 19, 2021

Uh oh!

rust-timer commented Nov 19, 2021

Uh oh!

bors commented Nov 19, 2021

Uh oh!

bors commented Nov 20, 2021

Uh oh!

rust-timer commented Nov 20, 2021

Uh oh!

rust-timer commented Nov 20, 2021

Uh oh!

Kobzol commented Nov 20, 2021

Uh oh!

jyn514 commented Nov 20, 2021

Uh oh!

Uh oh!

nagisa commented Dec 8, 2021

Uh oh!

Kobzol commented Dec 8, 2021

Uh oh!

nagisa commented Dec 8, 2021

Uh oh!

bors commented Dec 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants