Uh oh!
There was an error while loading. Please reload this page.
Add long error explanation for E0625 - #87715
Merged
Merged
Conversation
rust-highfive
commented
Aug 3, 2021
Contributor
Some changes occurred in diagnostic error codes |
rust-highfive
commented
Aug 3, 2021
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
petrochenkov
commented
Aug 3, 2021
Contributor
|
GuillaumeGomez
requested changes
Aug 3, 2021
GuillaumeGomez
left a comment
Member
There was a problem hiding this comment.
Please move the explanation after the failing example but otherwise looks good to me.
Uh oh!
There was an error while loading. Please reload this page.
petrochenkov
commented
Aug 4, 2021
Contributor
GuillaumeGomez
approved these changes
Aug 4, 2021
GuillaumeGomez
commented
Aug 4, 2021
Member
Thanks! r=me once CI pass |
GuillaumeGomez
commented
Aug 4, 2021
Member
@bors: r+ rollup squash |
bors
commented
Aug 4, 2021
Collaborator
📌 Commit dc5f6d2 has been approved by |
JohnTitor added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 6, 2021
…uillaumeGomez Add long error explanation for E0625 For rust-lang#61137.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#87561 (thread set_name haiku implementation.) - rust-lang#87715 (Add long error explanation for E0625) - rust-lang#87727 (explicit_generic_args_with_impl_trait: fix min expected number of generics) - rust-lang#87742 (Validate FFI-safety warnings on naked functions) - rust-lang#87756 (Add back -Zno-profiler-runtime) - rust-lang#87759 (Re-use std::sealed::Sealed in os/linux/process.) - rust-lang#87760 (Promote `aarch64-apple-ios-sim` to Tier 2) - rust-lang#87770 (permit drop impls with generic constants in where clauses) - rust-lang#87780 (alloc: Use intra doc links for the reserve function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
100 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #61137.