Uh oh!
There was an error while loading. Please reload this page.
Rollup of 10 pull requests - #87806
Closed
JohnTitor wants to merge 25 commits into
Closed
Conversation
Test that FFI-safety warnings don't get accidentally dropped on naked functions. The big picture is that if you implement a naked function with the Rust ABI you'll get a warning. Further, if you implement a naked function with a standardized ABI, but use non-FFI-safe types you will still get a warning. rust-lang/rfcs#2774rust-lang/rfcs#2972
This was removed by rust-lang#85284 in favor of -Zprofiler-runtime=<name>. However the suggested -Zprofiler-runtime=None doesn't work because "None" is treated as a crate name.
As per MCP#428[1] this target becomes Tier 2. [1]: rust-lang/compiler-team#428
The sentence exists to highlight the existence of a performance footgun of repeated calls of the reserve_exact function.
We now let `noop_flat_map_stmt` assign `NodeId`s (via `visit_id`), just as we do for other AST nodes.
…-comment, r=Mark-Simulacrum Ignore comments in tidy-filelength Ref rust-lang#60302 (comment)
…uillaumeGomez Add long error explanation for E0625 For rust-lang#61137.
explicit_generic_args_with_impl_trait: fix min expected number of generics Fixesrust-lang#87718 The problem was that `synth_type_param_count` was already subtracted from `named_type_param_count`, so this ended up being subtracted again. This caused `expected_min` to overflow, and ultimately resulting in weird and wrong behaviour. I've also added another test not present in the original issue but caused by the same bug.
Validate FFI-safety warnings on naked functions Test that FFI-safety warnings don't get accidentally dropped on naked functions. The big picture is that if you implement a naked function with the Rust ABI you'll get a warning. Further, if you implement a naked function with a standardized ABI, but use non-FFI-safe types you will still get a warning. rust-lang/rfcs#2774rust-lang/rfcs#2972 cc `````@joshtriplett````` `````@Amanieu````` `````@haraldh`````
…h726 Add back -Zno-profiler-runtime This was removed by rust-lang#85284 in favor of `-Zprofiler-runtime=<name>`.However the suggested `-Zprofiler-runtime=None` doesn't work because`None` is treated as a crate name.
Re-use std::sealed::Sealed in os/linux/process. This uses `std::sealed::Sealed` in `std::os::linux::process` instead of defining new `Sealed` traits there.
…rk-Simulacrum Promote `aarch64-apple-ios-sim` to Tier 2 As per rust-lang/compiler-team#428 this target becomes Tier 2. --- I tested that the latest nightly has the target and I'm already building my project with that on CI and locally.
permit drop impls with generic constants in where clauses Fixesrust-lang#79248 `==` is not sufficient to check for equality between unevaluated consts which causes the above issue because the const in `[(); N - 1]:` on the impl and the const in `[(); N - 1]:` on the struct def are not seen as equal. Any predicate that can contain an unevaluated const cant use `==` here as it will cause us to incorrectly emit an error. I dont know much about chalk but it seems like we ought to be relating the `TypeWellFormedFromEnv` instead of `==` as it contains a `Ty` so I added that too... r? `````@lcnr`````
Remove special case for statement `NodeId` assignment We now let `noop_flat_map_stmt` assign `NodeId`s (via `visit_id`), just as we do for other AST nodes.
alloc: Use intra doc links for the reserve function The sentence exists to highlight the existence of a performance footgun of repeated calls of the reserve_exact function.
JohnTitor
commented
Aug 6, 2021
MemberAuthor
@bors r+ p=10 rollup=never |
bors
commented
Aug 6, 2021
Collaborator
📌 Commit 0b3a5b0 has been approved by |
bors
commented
Aug 6, 2021
Collaborator
⌛ Testing commit 0b3a5b0 with merge a83f4ae8ca199be58807a5ca331fcd53c4dc747e... |
rust-log-analyzer
commented
Aug 6, 2021
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Aug 6, 2021
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
aarch64-apple-ios-simto Tier 2 #87760 (Promoteaarch64-apple-ios-simto Tier 2)NodeIdassignment #87779 (Remove special case for statementNodeIdassignment)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup