Skip to content

Revert "Remove optimization_fuel_crate from Session" - #88748

Merged
bors merged 1 commit into
rust-lang:masterfrom
bjorn3:try_fix_perf_regression
Sep 9, 2021
Merged

Revert "Remove optimization_fuel_crate from Session"#88748
bors merged 1 commit into
rust-lang:masterfrom
bjorn3:try_fix_perf_regression

Conversation

@bjorn3

@bjorn3bjorn3 commented Sep 8, 2021

Copy link
Copy Markdown
Member

This reverts commit 5464b2e.

This hopefully fixes the perf regression in #88530 (comment).

@rust-highfive

rust-highfive commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2021
@bjorn3

bjorn3 commented Sep 8, 2021

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Sep 8, 2021

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 8, 2021
@bors

bors commented Sep 8, 2021

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 1022646 with merge 74f6fa827dfc2894e627fea79cf03f0927c74911...

@bjorn3bjorn3 mentioned this pull request Sep 8, 2021
Merged
wesleywiser
wesleywiser approved these changes Sep 8, 2021
View reviewed changes

@wesleywiserwesleywiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if the perf looks good

@bors

bors commented Sep 8, 2021

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 74f6fa827dfc2894e627fea79cf03f0927c74911 (74f6fa827dfc2894e627fea79cf03f0927c74911)

@rust-timer

rust-timer commented Sep 8, 2021

Copy link
Copy Markdown
Collaborator

Queued 74f6fa827dfc2894e627fea79cf03f0927c74911 with parent 434cb43, future comparison URL.

@rust-timer

rust-timer commented Sep 8, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (74f6fa827dfc2894e627fea79cf03f0927c74911): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

  • Large improvement in instruction counts (up to -2.7% on full builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 8, 2021
@bjorn3

bjorn3 commented Sep 8, 2021

Copy link
Copy Markdown
MemberAuthor

This fixes the worst of the perf regression, but not completely.

@bors r=wesleywiser

@bors

bors commented Sep 8, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 1022646 has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2021
@bors

bors commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1022646 with merge 02a57fa...

@bors

bors commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 02a57fa to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2021
@bors
bors merged commit 02a57fa into rust-lang:masterSep 9, 2021
@rustbotrustbot added this to the 1.57.0 milestone Sep 9, 2021
@rust-timer

rust-timer commented Sep 9, 2021

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (02a57fa): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@bjorn3
bjorn3 deleted the try_fix_perf_regression branch September 9, 2021 14:49
@bjorn3

bjorn3 commented Sep 9, 2021

Copy link
Copy Markdown
MemberAuthor

Why didn't this result in a perf improvement after all?

@tmiaskotmiasko mentioned this pull request Sep 28, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@wesleywiserwesleywiser

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

6 participants

@bjorn3@rust-highfive@rust-timer@bors@wesleywiser@rustbot