Skip to content

Reapply "Remove optimization_fuel_crate from Session" - #89322

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:rm-optimization-fuel
Oct 1, 2021
Merged

Reapply "Remove optimization_fuel_crate from Session"#89322
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:rm-optimization-fuel

Conversation

@tmiasko

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2021
@tmiasko

Copy link
Copy Markdown
ContributorAuthor

This change was identified as performance regression and reverted. It turns out that the regression was in an unrelated area of the compiler and fixed after splitting the mir crate, before revert even landed.

cc @bjorn3

@michaelwoerister

Copy link
Copy Markdown
Member

Thanks, @tmiasko!
@bors r+ rollup

@bors

bors commented Oct 1, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 42e9dfd has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2021
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Oct 1, 2021
…haelwoerister
Reapply "Remove optimization_fuel_crate from Session"
@fee1-deadfee1-dead mentioned this pull request Oct 1, 2021
@ManishearthManishearth mentioned this pull request Oct 1, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2021
…arth
Rollup of 6 pull requests
Successful merges:
- rust-lang#87868 (Added -Z randomize-layout flag)
- rust-lang#88820 (Add `pie` as another `relocation-model` value)
- rust-lang#89029 (feat(rustc_parse): recover from pre-RFC-2000 const generics syntax)
- rust-lang#89322 (Reapply "Remove optimization_fuel_crate from Session")
- rust-lang#89340 (Improve error message for `printf`-style format strings)
- rust-lang#89415 (Correct caller/callsite confusion in inliner message)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 2f67063 into rust-lang:masterOct 1, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 1, 2021
@tmiasko
tmiasko deleted the rm-optimization-fuel branch October 1, 2021 20:07
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Oct 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tmiasko@rust-highfive@michaelwoerister@bors@rustbot@bjorn3