Move encode_metadata out of CrateStore. by cjgillot · Pull Request #89183 · rust-lang/rust

cjgillot · 2021-09-22T20:32:58Z

rustc_metadata is already accessible by all client crates. It does not need to be called trough a trait object.

rust-highfive · 2021-09-22T20:33:01Z

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

rust-highfive · 2021-09-22T20:33:02Z

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

bjorn3 · 2021-09-22T22:44:59Z

Can you move EncodedMetadata to rustc_metadata?

Mark-Simulacrum · 2021-09-22T23:05:30Z

@bors try @rust-timer queue

Calls through a trait object might be saving us some codegen time and such (if things are not getting inlined, etc.). Seems unlikely, but worth checking, I think.

rust-timer · 2021-09-22T23:05:31Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-09-22T23:05:55Z

⌛ Trying commit 53cd5168934f0567537415e54fe9d36aa86089bd with merge bb92ee19d26561c6b263a4c79e77c0b2dc084980...

bors · 2021-09-23T00:26:05Z

☀️ Try build successful - checks-actions
Build commit: bb92ee19d26561c6b263a4c79e77c0b2dc084980 (bb92ee19d26561c6b263a4c79e77c0b2dc084980)

rust-timer · 2021-09-23T00:26:06Z

Queued bb92ee19d26561c6b263a4c79e77c0b2dc084980 with parent 308dffd, future comparison URL.

rust-timer · 2021-09-23T02:03:47Z

Finished benchmarking commit (bb92ee19d26561c6b263a4c79e77c0b2dc084980): comparison url.

Summary: This change led to small relevant regressions 😿 in compiler performance.

Small regression in instruction counts (up to 0.5% on incr-unchanged builds of helloworld)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

bors · 2021-09-27T02:47:53Z

☔ The latest upstream changes (presumably #89092) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2021-09-28T12:26:52Z

the change lgtm, but considering it's just a redesign, but regresses perf, should we really do this? Do you need this for some other PRs?

cjgillot · 2021-09-28T20:57:42Z

@bors try @rust-timer queue

rust-timer · 2021-09-28T20:57:43Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-09-28T20:57:54Z

⌛ Trying commit c013cd38c94f26e9fd03b73db411530d87ad2dff with merge afea9a948dbff21b30109ada462b7bda076ac676...

bors · 2021-09-28T22:20:44Z

☀️ Try build successful - checks-actions
Build commit: afea9a948dbff21b30109ada462b7bda076ac676 (afea9a948dbff21b30109ada462b7bda076ac676)

rust-timer · 2021-09-28T22:20:45Z

Queued afea9a948dbff21b30109ada462b7bda076ac676 with parent 8f8092c, future comparison URL.

rust-timer · 2021-09-29T00:49:46Z

Finished benchmarking commit (afea9a948dbff21b30109ada462b7bda076ac676): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>

oli-obk · 2021-09-30T20:48:57Z

@bors r+

bors · 2021-09-30T20:48:59Z

📌 Commit 2d51b78 has been approved by oli-obk

bors · 2021-10-01T00:35:43Z

⌛ Testing commit 2d51b78 with merge 1c0ed0d...

bors · 2021-10-01T03:23:10Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1c0ed0d to master...

rust-timer · 2021-10-01T07:57:06Z

Finished benchmarking commit (1c0ed0d): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Move ICH to rustc_query_system Based on rust-lang#89183 The StableHashingContext does not need to be in rustc_middle. This PR moves it to rustc_query_system. This will avoid a dependency between rustc_ast_lowering and rustc_middle in rust-lang#89124.

Move ICH to rustc_query_system Based on rust-lang/rust#89183 The StableHashingContext does not need to be in rustc_middle. This PR moves it to rustc_query_system. This will avoid a dependency between rustc_ast_lowering and rustc_middle in rust-lang/rust#89124.

rust-highfive assigned oli-obk Sep 22, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2021

bjorn3 reviewed Sep 22, 2021
View reviewed changes

Comment threadcompiler/rustc_codegen_cranelift/scripts/filter_profile.rs Outdated

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 22, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 23, 2021

cjgillot force-pushed the noenc branch from 53cd516 to c863b58Compare September 24, 2021 16:17

This comment has been minimized.
Sign in to view

cjgillot force-pushed the noenc branch from c863b58 to 9088d69Compare September 24, 2021 19:16

cjgillot mentioned this pull request Sep 26, 2021
Move ICH to rustc_query_system #89266
Merged

cjgillot force-pushed the noenc branch from bf52a50 to c013cd3Compare September 28, 2021 20:15

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 28, 2021

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Sep 29, 2021

cjgillotand others added 5 commits September 30, 2021 19:41

Move encode_metadata out of CrateStore.
df54d39

Move EncodedMetadata to rustc_metadata.
b244b98

Update run-make-fulldeps.
ea6b799

Update compiler/rustc_codegen_cranelift/scripts/filter_profile.rs
79d1475
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>

Rebase fallout.
2d51b78

cjgillot force-pushed the noenc branch from c013cd3 to 2d51b78Compare September 30, 2021 19:09

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 1, 2021

bors merged commit 1c0ed0d into rust-lang:masterOct 1, 2021

rustbot added this to the 1.57.0 milestone Oct 1, 2021

This was referenced Oct 1, 2021
Direct users towards using Rust target feature names in CLI #87402
Merged
Index and hash HIR as part of lowering #89124
Merged
Remove LocalDefId <-> HirId global maps #89278
Closed

cjgillot deleted the noenc branch October 1, 2021 18:03

Uh oh!

Uh oh!

Conversation

cjgillot commented Sep 22, 2021

Uh oh!

rust-highfive commented Sep 22, 2021

Uh oh!

rust-highfive commented Sep 22, 2021

Uh oh!

bjorn3 commented Sep 22, 2021

Uh oh!

Uh oh!

Mark-Simulacrum commented Sep 22, 2021

Uh oh!

rust-timer commented Sep 22, 2021

Uh oh!

bors commented Sep 22, 2021

Uh oh!

bors commented Sep 23, 2021

Uh oh!

rust-timer commented Sep 23, 2021

Uh oh!

rust-timer commented Sep 23, 2021

Uh oh!

This comment has been minimized.

bors commented Sep 27, 2021

Uh oh!

oli-obk commented Sep 28, 2021

Uh oh!

cjgillot commented Sep 28, 2021

Uh oh!

rust-timer commented Sep 28, 2021

Uh oh!

bors commented Sep 28, 2021

Uh oh!

bors commented Sep 28, 2021

Uh oh!

rust-timer commented Sep 28, 2021

Uh oh!

rust-timer commented Sep 29, 2021

Uh oh!

oli-obk commented Sep 30, 2021

Uh oh!

bors commented Sep 30, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants