Move ICH to rustc_query_system by cjgillot · Pull Request #89266 · rust-lang/rust

cjgillot · 2021-09-26T10:01:45Z

Based on #89183

The StableHashingContext does not need to be in rustc_middle.

This PR moves it to rustc_query_system. This will avoid a dependency between rustc_ast_lowering and rustc_middle in #89124.

rust-highfive · 2021-09-26T10:01:48Z

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

rust-highfive · 2021-09-26T10:01:49Z

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

bors · 2021-09-27T02:50:32Z

☔ The latest upstream changes (presumably #89092) made this pull request unmergeable. Please resolve the merge conflicts.

davidtwco

This all seems sensible to me, but I'll reassign to get another opinion.

davidtwco · 2021-09-27T12:26:08Z

r? @michaelwoerister

cjgillot · 2021-09-28T21:18:58Z

Actually, putting it in rustc_query_system would be more consistent.

michaelwoerister · 2021-10-01T08:48:08Z

Looks good to me. Thanks, @cjgillot!

Let's do a perf run for good measure:
@bors try @rust-timer queue

If that doesn't yield any surprises, r=davidtwco,michaelwoerister after rebasing and updating the PR message.

rust-timer · 2021-10-01T08:48:09Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-10-01T08:48:16Z

⌛ Trying commit 64a8296404f34e1d6eb70fc8403719eca6d34843 with merge 0167f490eac64cc5491f7207f726854e923cda54...

bors · 2021-10-01T09:59:42Z

☀️ Try build successful - checks-actions
Build commit: 0167f490eac64cc5491f7207f726854e923cda54 (0167f490eac64cc5491f7207f726854e923cda54)

rust-timer · 2021-10-01T09:59:44Z

Queued 0167f490eac64cc5491f7207f726854e923cda54 with parent 598d89b, future comparison URL.

rust-timer · 2021-10-01T12:49:59Z

Finished benchmarking commit (0167f490eac64cc5491f7207f726854e923cda54): comparison url.

Summary: This change led to moderate relevant regressions 😿 in compiler performance.

Moderate regression in instruction counts (up to 1.1% on incr-unchanged builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

rust-timer · 2021-10-03T17:55:33Z

Finished benchmarking commit (376d7982c5989bfb7db8ef162de7e442e7168d62): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

Moderate improvement in instruction counts (up to -0.8% on incr-unchanged builds of externs)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

michaelwoerister · 2021-10-04T08:01:48Z

Performance looks good now 👍

@bors r+

bors · 2021-10-04T08:01:50Z

📌 Commit b2ed9c4 has been approved by michaelwoerister

bors · 2021-10-04T15:30:47Z

⌛ Testing commit b2ed9c4 with merge 6f7dab50d103a74c5130a3ebf578ade0467ee02e...

bors · 2021-10-04T19:45:47Z

💥 Test timed out

cjgillot · 2021-10-04T19:48:08Z

@bors retry

rust-log-analyzer · 2021-10-04T19:53:08Z

A job failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2021-10-05T09:45:15Z

⌛ Testing commit b2ed9c4 with merge 55111d6...

bors · 2021-10-05T12:52:34Z

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 55111d6 to master...

rust-timer · 2021-10-05T14:31:18Z

Finished benchmarking commit (55111d6): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

rust-highfive assigned davidtwco Sep 26, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2021

This comment has been minimized.
Sign in to view

cjgillot force-pushed the session-ich branch from 7d47db7 to e157524Compare September 26, 2021 15:08

davidtwco reviewed Sep 27, 2021
View reviewed changes

rust-highfive assigned michaelwoerister and unassigned davidtwco Sep 27, 2021

cjgillot force-pushed the session-ich branch from e157524 to 974ef80Compare September 28, 2021 20:16

cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2021

cjgillot force-pushed the session-ich branch from 974ef80 to 336737fCompare September 29, 2021 21:14

This comment has been minimized.
Sign in to view

cjgillot force-pushed the session-ich branch 2 times, most recently from e2a2c86 to 64a8296Compare September 30, 2021 19:09

michaelwoerister approved these changes Oct 1, 2021
View reviewed changes

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 1, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 1, 2021

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Oct 3, 2021

cjgillot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 3, 2021

cjgillot marked this pull request as ready for review October 3, 2021 18:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 5, 2021

bors merged commit 55111d6 into rust-lang:masterOct 5, 2021

rustbot added this to the 1.57.0 milestone Oct 5, 2021

This was referenced Oct 5, 2021
Remove some eval_always #86056
Closed
extend simplify_type#86986
Merged
[WIP] parameterize -C prefer-dynamic#88101
Closed
Refactor fingerprint reconstruction #89343
Merged
Correct decoding of foreign expansions during incr. comp. #89476
Merged

cjgillot deleted the session-ich branch October 5, 2021 21:34

Uh oh!

Uh oh!

Conversation

cjgillot commented Sep 26, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 26, 2021

Uh oh!

rust-highfive commented Sep 26, 2021

Uh oh!

This comment has been minimized.

bors commented Sep 27, 2021

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

davidtwco commented Sep 27, 2021

Uh oh!

cjgillot commented Sep 28, 2021

Uh oh!

This comment has been minimized.

michaelwoerister commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

bors commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 1, 2021

Uh oh!

rust-timer commented Oct 3, 2021

Uh oh!

michaelwoerister commented Oct 4, 2021

Uh oh!

bors commented Oct 4, 2021

Uh oh!

bors commented Oct 4, 2021

Uh oh!

bors commented Oct 4, 2021

Uh oh!

cjgillot commented Oct 4, 2021

Uh oh!

rust-log-analyzer commented Oct 4, 2021

Uh oh!

bors commented Oct 5, 2021

Uh oh!

bors commented Oct 5, 2021

Uh oh!

rust-timer commented Oct 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cjgillot commented Sep 26, 2021•
edited
Loading