Uh oh!
There was an error while loading. Please reload this page.
Various fixes for const_trait_impl - #89359
Merged
Merged
Conversation
rust-highfive
commented
Sep 29, 2021
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
jackh726
commented
Oct 21, 2021
Member
r? @oli-obk |
bors
commented
Oct 23, 2021
Collaborator
☔ The latest upstream changes (presumably #90104) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
There was a problem hiding this comment.
So ~const Drop bounds already are unlike Drop bounds in that the type does not have to actually implement the Drop trait. Is this noted anywhere?
MemberAuthor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Ok. That makes sense now, seeing as there isn't really any other way to easily do it.
oli-obk
commented
Nov 18, 2021
Contributor
makes sense r=me after a rebase |
This comment has been minimized.
This comment has been minimized.
fee1-dead
commented
Nov 24, 2021
MemberAuthor
@bors r=oli-obk |
bors
commented
Nov 24, 2021
Collaborator
📌 Commit 4f29f3c has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 24, 2021
Various fixes for const_trait_impl A few problems I found while making `Iterator` easier to const-implement. 1. More generous `~const Drop` check. We check for nested fields with caller bounds. For example, an ADT type with fields of types `A`, `B`, `C`, check if all of them are either: - Bounded (`A: ~const Drop`, `B: Copy`) - Known to be able to destruct at compile time (`C = i32`, `struct C(i32)`, `C = some_fn`) 2. Don't treat trait functions marked with `#[default_method_body_is_const]` as stable const fns when checking `const_for` and `const_try` feature gates. I think anyone can review this, so no r? this time.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
Various fixes for const_trait_impl A few problems I found while making `Iterator` easier to const-implement. 1. More generous `~const Drop` check. We check for nested fields with caller bounds. For example, an ADT type with fields of types `A`, `B`, `C`, check if all of them are either: - Bounded (`A: ~const Drop`, `B: Copy`) - Known to be able to destruct at compile time (`C = i32`, `struct C(i32)`, `C = some_fn`) 2. Don't treat trait functions marked with `#[default_method_body_is_const]` as stable const fns when checking `const_for` and `const_try` feature gates. I think anyone can review this, so no r? this time.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
Various fixes for const_trait_impl A few problems I found while making `Iterator` easier to const-implement. 1. More generous `~const Drop` check. We check for nested fields with caller bounds. For example, an ADT type with fields of types `A`, `B`, `C`, check if all of them are either: - Bounded (`A: ~const Drop`, `B: Copy`) - Known to be able to destruct at compile time (`C = i32`, `struct C(i32)`, `C = some_fn`) 2. Don't treat trait functions marked with `#[default_method_body_is_const]` as stable const fns when checking `const_for` and `const_try` feature gates. I think anyone can review this, so no r? this time.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#89359 (Various fixes for const_trait_impl) - rust-lang#90499 (Link with default MACOSX_DEPLOYMENT_TARGET if not otherwise specified.) - rust-lang#91096 (Print associated types on opaque `impl Trait` types) - rust-lang#91111 (Do not visit attributes in `ItemLowerer`.) - rust-lang#91162 (explain why CTFE/Miri perform truncation on shift offset) - rust-lang#91185 (Remove `-Z force-overflow-checks`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few problems I found while making
Iteratoreasier to const-implement.~const Dropcheck.We check for nested fields with caller bounds.
For example, an ADT type with fields of types
A,B,C, check if all of them are either:A: ~const Drop,B: Copy)C = i32,struct C(i32),C = some_fn)#[default_method_body_is_const]as stable const fns when checkingconst_forandconst_tryfeature gates.I think anyone can review this, so no r? this time.